TODO and SKIP tests are not taken as failed/passed

Author: jacobmendoza

lib/panel.js

@@ -28,13 +28,20 @@ class Panel {
 		const assert = assertResult.assert;
 
 		const newTest = this.htmlRendererHelper.createContainer('test');
-		newTest.classList.add(assert.ok ? 'ok' : 'ko');
+		newTest.classList.add(this._getCssClassForAssert(assert));
 		newTest.textContent = `${assert.name}`;
 		this.testsContainer.appendChild(newTest);
 
 		this._updateTestStatisticSection(assertResult);
 	}
 
+	_getCssClassForAssert(assert) {
+		if (assert.ok) {
+			return (assert.skip) ? 'skipped' : 'ok';
+		}
+		return (assert.todo) ? 'todo' : 'ko';
+	}
+
 	renderFinalReport(results) {
 		this.hideExecutingIndicator();
 

lib/test-runner-process.js

@@ -55,8 +55,10 @@ class TestRunnerProcess extends EventEmitter {
 
 	_updateCurrentExecution(assert) {
 		if (assert.ok) {
-			this.currentExecution.passed++;
-		} else {
+			if (!assert.skip) {
+				this.currentExecution.passed++;
+			}
+		} else if (!assert.todo) {
 			this.currentExecution.failed++;
 		}
 	}

spec/test-runner-process-spec.js

@@ -99,4 +99,30 @@ describe('TestRunnerProcess', () => {
 		expect(receivedAssertResults[1].assert).toBe(notOkAssertResult);
 		expect(receivedAssertResults[1].currentExecution.passed).toBe(1);
 	});
+
+	it('does not count skipped tests as success', () => {
+		const receivedAssertResults = [];
+		const assertResult = {ok: true, skip: true};
+		runner.run('/somefolder/', 'filename');
+		runner.on('assert', result => receivedAssertResults.push(result));
+
+		parser.emitAssert(assertResult);
+
+		expect(receivedAssertResults[0].assert).toBe(assertResult);
+		expect(receivedAssertResults[0].currentExecution.passed).toBe(0);
+		expect(receivedAssertResults[0].currentExecution.failed).toBe(0);
+	});
+
+	it('does not count todo tests as failed', () => {
+		const receivedAssertResults = [];
+		const assertResult = {ok: false, todo: true};
+		runner.run('/somefolder/', 'filename');
+		runner.on('assert', result => receivedAssertResults.push(result));
+
+		parser.emitAssert(assertResult);
+
+		expect(receivedAssertResults[0].assert).toBe(assertResult);
+		expect(receivedAssertResults[0].currentExecution.passed).toBe(0);
+		expect(receivedAssertResults[0].currentExecution.failed).toBe(0);
+	});
 });

styles/ava.less

@@ -73,6 +73,8 @@
 
 		.ok { color: #6D9669; }
 		.ko { color: #B03952; }
+		.skipped { color: #CCC; }
+		.todo { color: #CCC; }
 	}
 
 	.message { padding-bottom: 10px; }