Skip to content

Commit f2c0709

Browse files
committed
Merge pull request #664 from kentcdodds/pr/update-contributing
add note about AVA mantra in contributing guidelines
2 parents d2e0c64 + d306c4a commit f2c0709

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

contributing.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,3 +45,5 @@ We have a [chat](https://gitter.im/sindresorhus/ava). Jump in there and lurk, ta
4545
- Use a clear and descriptive title for the pull request and commits.
4646
- Write a convincing description of why we should land your pull request. It's your job to convince us. Answer "why" it's needed and provide use-cases.
4747
- You might be asked to do changes to your pull request. There's never a need to open another pull request. [Just update the existing one.](https://github.com/RichardLitt/docs/blob/master/amending-a-commit-guide.md)
48+
49+
Note: when making code changes, try to remember AVA's mantra (stolen from Python) of having preferably one way to do something. For example, a request to add an alias to part of the API ([like this](https://github.com/sindresorhus/ava/pull/663)) will likely be rejected without some other substantial benefit.

0 commit comments

Comments
 (0)