Skip to content

Commit fb3af50

Browse files
nfcamposjamestalmage
authored andcommitted
update to new power-assert-runtime (#903)
* updated to power-assert-runtime * added tests for power assert not throwing on experimental syntax * bump empower-core to 0.6.1
1 parent 60890c4 commit fb3af50

File tree

5 files changed

+41
-12
lines changed

5 files changed

+41
-12
lines changed

lib/caching-precompiler.js

+1
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,7 @@ CachingPrecompiler.prototype._createEspowerPlugin = function () {
155155

156156
// initialize power-assert
157157
return createEspowerPlugin(this.babel, {
158+
embedAst: true,
158159
patterns: enhanceAssert.PATTERNS
159160
});
160161
};

lib/enhance-assert.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -47,14 +47,14 @@ function enhanceAssert(opts) {
4747
}
4848

4949
function formatter() {
50-
var powerAssertFormatter = require('power-assert-formatter');
51-
var powerAssertRenderers = require('power-assert-renderers');
50+
var createFormatter = require('power-assert-context-formatter');
51+
var SuccinctRenderer = require('power-assert-renderer-succinct');
52+
var AssertionRenderer = require('power-assert-renderer-assertion');
5253

53-
return powerAssertFormatter({
54-
maxDepth: 3,
54+
return createFormatter({
5555
renderers: [
56-
powerAssertRenderers.AssertionRenderer,
57-
powerAssertRenderers.SuccinctRenderer
56+
{ctor: AssertionRenderer},
57+
{ctor: SuccinctRenderer, options: {maxDepth: 3}}
5858
]
5959
});
6060
}

package.json

+6-4
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@
8787
"babel-core": "^6.3.21",
8888
"babel-plugin-ava-throws-helper": "0.0.4",
8989
"babel-plugin-detective": "^1.0.2",
90-
"babel-plugin-espower": "^2.1.0",
90+
"babel-plugin-espower": "^2.2.0",
9191
"babel-plugin-transform-runtime": "^6.3.13",
9292
"babel-preset-es2015": "^6.3.13",
9393
"babel-preset-stage-2": "^6.3.13",
@@ -104,7 +104,7 @@
104104
"convert-source-map": "^1.2.0",
105105
"core-assert": "^0.2.0",
106106
"debug": "^2.2.0",
107-
"empower-core": "^0.5.0",
107+
"empower-core": "^0.6.1",
108108
"figures": "^1.4.0",
109109
"find-cache-dir": "^0.1.1",
110110
"fn-name": "^2.0.0",
@@ -132,8 +132,9 @@
132132
"package-hash": "^1.1.0",
133133
"pkg-conf": "^1.0.1",
134134
"plur": "^2.0.0",
135-
"power-assert-formatter": "^1.3.0",
136-
"power-assert-renderers": "^0.1.0",
135+
"power-assert-context-formatter": "^1.0.4",
136+
"power-assert-renderer-assertion": "^1.0.1",
137+
"power-assert-renderer-succinct": "^1.0.1",
137138
"pretty-ms": "^2.0.0",
138139
"repeating": "^2.0.0",
139140
"require-precompiled": "^0.1.0",
@@ -149,6 +150,7 @@
149150
"update-notifier": "^0.7.0"
150151
},
151152
"devDependencies": {
153+
"babel-preset-react": "^6.5.0",
152154
"cli-table2": "^0.2.0",
153155
"coveralls": "^2.11.4",
154156
"delay": "^1.3.0",

test/api.js

+16-2
Original file line numberDiff line numberDiff line change
@@ -650,9 +650,13 @@ function generateTests(prefix, apiCreator) {
650650
});
651651

652652
test(prefix + 'power-assert support', function (t) {
653-
t.plan(3);
653+
t.plan(5);
654654

655-
var api = apiCreator();
655+
var api = apiCreator({
656+
babelConfig: {
657+
presets: ['react', 'es2015', 'stage-2']
658+
}
659+
});
656660

657661
api.run([path.join(__dirname, 'fixture/power-assert.js')])
658662
.then(function (result) {
@@ -667,6 +671,16 @@ function generateTests(prefix, apiCreator) {
667671
result.errors[1].error.message,
668672
/with message\s+t\.true\(a === 'foo', 'with message'\)\s*\n\s+\|\s*\n\s+"bar"/m
669673
);
674+
675+
t.match(
676+
result.errors[2].error.message,
677+
/t\.true\(o === \{ ...o \}\)\s*\n\s+\|\s*\n\s+Object\{\}/m
678+
);
679+
680+
t.match(
681+
result.errors[3].error.message,
682+
/t\.true\(<div \/> === <span \/>\)/m
683+
);
670684
});
671685
});
672686

test/fixture/power-assert.js

+12
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,15 @@ test.serial(t => {
1111

1212
t.true(a === 'foo', 'with message');
1313
});
14+
15+
test.serial(t => {
16+
const o = {};
17+
18+
t.true(o === {...o});
19+
});
20+
21+
test.serial(t => {
22+
const React = { createElement: function(type) { return type } }
23+
24+
t.true(<div /> === <span />);
25+
});

0 commit comments

Comments
 (0)