Skip to content

Horizontal rule between successful runs with logs #1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jamiebuilds opened this issue Aug 24, 2018 · 9 comments
Closed

Horizontal rule between successful runs with logs #1917

jamiebuilds opened this issue Aug 24, 2018 · 9 comments
Labels
blocked waiting on something else to be resolved first 💵 Funded on Issuehunt This issue has been funded on Issuehunt enhancement new functionality help wanted scope:reporters scope:watch-mode

Comments

@jamiebuilds
Copy link
Contributor

jamiebuilds commented Aug 24, 2018

Issuehunt badges

In watch mode, if you log something in your code while working on tests, it will look like this:

# ... previous failures ...
─────────────────────────────────────
'logged value'

  1 passed [11:44:22]

On the next run it will look like this:

# ... previous failures ...
─────────────────────────────────────
'logged value'
'logged value'

  1 passed [11:44:32]

This is okay for small values like 'logged value', but when you are logging lots of things including large objects it would be nice for some visual separation.

What if AVA added another horizontal rule in between sets of logs?

# ... previous failures ...
─────────────────────────────────────
'logged value'
─────────────────────────────────────
'logged value'

  1 passed [11:44:32]

This would make it much more clear what run the logs were from.

There is a $40.00 open bounty on this issue. Add more on Issuehunt.

@novemberborn
Copy link
Member

What do you mean by "log"? stdout / stderr?

I think it may be less confusing if you use verbose mode, IIRC that always writes the separator. But maybe this makes sense for the default mode. It's just that the reporters are a bit of a mess.

@jamiebuilds
Copy link
Contributor Author

I mean console.log, but I'm assuming AVA already has pipes of all the user's stdout/stderr and can detect if they wrote anything.

@novemberborn
Copy link
Member

Yea, makes sense.

I tried to figure out how this stuff currently works and I couldn't in a reasonable amount of time. Will add the appropriate labels and leave this open, but it may be something to be done as part of #1776.

@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label May 10, 2019
@IssueHuntBot
Copy link

@IssueHunt has funded $40.00 to this issue.


@yovasx2
Copy link
Contributor

yovasx2 commented Aug 6, 2019

I think you can only wrap your logged object in a couple of rulers:

console.log("___________________________")
console.log(big_obj); 
console.log("___________________________")

@yovasx2
Copy link
Contributor

yovasx2 commented Aug 6, 2019

Also we cannot fix this since t.log() is broken for mini reporter: #2201

@m5x5
Copy link
Contributor

m5x5 commented May 12, 2020

@novemberborn You referenced this issue in #2217, but it seems like this enhancement isn't related to #2217, isn't it? I feel like this issue should be marked as blocked, since we cannot work on this issue, as long we haven't closed #2217.

@novemberborn novemberborn added the blocked waiting on something else to be resolved first label May 12, 2020
@novemberborn
Copy link
Member

@Michael55555 sure, thanks.

@novemberborn
Copy link
Member

Both due to the age of this issue, and the state of our reporters, I've decided to roll this into #2501.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked waiting on something else to be resolved first 💵 Funded on Issuehunt This issue has been funded on Issuehunt enhancement new functionality help wanted scope:reporters scope:watch-mode
Projects
None yet
Development

No branches or pull requests

5 participants