Skip to content

t.skipIf syntax #2602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jamestalmage opened this issue Oct 18, 2020 · 1 comment
Closed

t.skipIf syntax #2602

jamestalmage opened this issue Oct 18, 2020 · 1 comment
Labels

Comments

@jamestalmage
Copy link
Contributor

I've got a handful of tests I can't run in CI. Some I can only run in Windows, etc.

Proposed sytax:

  test.skipIf(isCI).skipIf(!isWindows)('test title', t => {
  })
@novemberborn
Copy link
Member

Hi @jamestalmage!

With #2435 I started tinkering with a "forkable test interface". So you could do something like:

const windowsOnly = test.make({ if: () => isWindows })
windowsOnly('test title', t => {})

Ultimately I think that's more versatile than adding lots of hooks to the regular test interface. What do you think?

(I'm closing this issue for housekeeping purposes, but let's keep the conversation going.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants