switch to new version of telemetry (#2717)

* switch to new version of telemetry

* fix tests

* PR feedback and misc changes

* move attachUnhandledExceptionListeners

* add TelemetryPayloadExporterFactory, tests, and update dependency logic

* loosen assertions on memory

* hopefully fixes checks

* update api.md

* update unflatten helper and add total to sandbox error span

* some PR feedback

* more PR feedback and add back telemetry v1

* utilize forceFlush and update noop telemetry to span processor level

* more PR feedback

* update changeset

* add span attribute limit and logic to handle in exporter

* fix lint

* update exports from telemetry_payload.ts

* PR feedback

Author: rtpascual

.changeset/famous-cities-appear.md

@@ -0,0 +1,9 @@
+---
+'@aws-amplify/platform-core': minor
+'@aws-amplify/cli-core': patch
+'@aws-amplify/sandbox': patch
+'@aws-amplify/backend-cli': patch
+'@aws-amplify/backend-deployer': patch
+---
+
+switch to new version of telemetry

.eslint_dictionary.json

@@ -70,6 +70,7 @@
   "filepath",
   "filesystem",
   "formatter",
+  "freemem",
   "frontend",
   "frontends",
   "frontmatter",
@@ -189,6 +190,7 @@
   "todos",
   "toggleable",
   "tokenized",
+  "totalmem",
   "totp",
   "tsbuildinfo",
   "tsc",
@@ -200,6 +202,9 @@
   "typeof",
   "ubuntu",
   "unauth",
+  "unflatten",
+  "unflattens",
+  "unflattened",
   "unix",
   "unlink",
   "unshallow",

.github/dependabot.yml

@@ -38,6 +38,9 @@ updates:
       inquirer:
         patterns:
           - '@inquirer/*'
+      opentelemetry:
+        patterns:
+          - '@opentelemetry/*'
       smithy:
         patterns:
           - '@smithy/*'

package-lock.json

@@ -154,6 +154,14 @@ export class CDKDeployer implements BackendDeployer {
             : HotswapMode.FULL_DEPLOYMENT,
       });
     } catch (error) {
+      await this.ioHost.notify({
+        message: 'Deployment failed',
+        code: 'DEPLOY_FAILED',
+        action: 'amplify',
+        time: new Date(),
+        level: 'error',
+        data: undefined,
+      });
       throw this.cdkErrorMapper.getAmplifyError(error as Error, backendId.type);
     }
 

packages/backend-deployer/src/cdk_deployer.ts

@@ -22,6 +22,7 @@
     "@aws-amplify/platform-core": "^1.8.0",
     "@aws-sdk/client-cloudformation": "^3.750.0",
     "@inquirer/prompts": "^7.3.2",
+    "@opentelemetry/api": "^1.9.0",
     "execa": "^9.5.1",
     "kleur": "^4.1.5",
     "ora": "8.2.0",

packages/cli-core/package.json

@@ -10,6 +10,11 @@ import { WriteStream } from 'node:tty';
 import { RewritableBlock } from './cfn-deployment-progress/rewritable_block.js';
 import { AmplifyIOEventsBridgeSingletonFactory } from './amplify_io_events_bridge_singleton_factory.js';
 import { EOL } from 'node:os';
+import {
+  context as openTelemetryContext,
+  trace as openTelemetryTrace,
+} from '@opentelemetry/api';
+import { setSpanAttributes } from '@aws-amplify/platform-core';
 
 /**
  * Amplify events logger class. Implements several loggers that connect
@@ -18,6 +23,7 @@ import { EOL } from 'node:os';
 export class AmplifyEventLogger {
   private cfnDeploymentProgressLogger: CfnDeploymentProgressLogger | undefined;
   private outputs = {};
+  private isHotSwap = false;
 
   /**
    * a logger instance to be used for CDK events
@@ -112,6 +118,9 @@ export class AmplifyEventLogger {
       case 'DEPLOY_STARTED':
         this.printer.stopSpinner();
         break;
+      case 'DEPLOY_FAILED':
+        this.isHotSwap = false;
+        return;
       case 'AMPLIFY_CFN_PROGRESS_UPDATE':
         if (!this.printer.isSpinnerRunning()) {
           this.printer.startSpinner('Deployment in progress...');
@@ -147,6 +156,7 @@ export class AmplifyEventLogger {
       );
       let message = msg.message;
       if (hotswappedResources && hotswappedResources.length > 0) {
+        this.isHotSwap = true;
         message = hotswappedResources
           .map(
             (resource) =>
@@ -202,6 +212,21 @@ export class AmplifyEventLogger {
             )}`,
           );
         }
+        const span = openTelemetryTrace.getSpan(openTelemetryContext.active());
+        if (this.isHotSwap && span) {
+          setSpanAttributes(span, {
+            latency: {
+              hotSwap: msg.data.duration,
+            },
+          });
+          this.isHotSwap = false;
+        } else if (span) {
+          setSpanAttributes(span, {
+            latency: {
+              deployment: msg.data.duration,
+            },
+          });
+        }
       }
     }
   };

packages/cli-core/src/loggers/amplify_event_loggers.ts

@@ -50,6 +50,9 @@
     "@aws-sdk/credential-provider-ini": "^3.750.0",
     "@aws-sdk/credential-providers": "^3.750.0",
     "@aws-sdk/region-config-resolver": "^3.734.0",
+    "@opentelemetry/api": "^1.9.0",
+    "@opentelemetry/context-async-hooks": "^2.0.0",
+    "@opentelemetry/sdk-trace-base": "^2.0.0",
     "@smithy/node-config-provider": "^4.0.1",
     "@smithy/shared-ini-file-loader": "^4.0.1",
     "envinfo": "^7.11.0",