Skip to content

fix: move default operator outside of guard statement #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Conversation

lawmicha
Copy link
Contributor

@lawmicha lawmicha commented Sep 2, 2020

Issue #, if available:
#748

Description of changes:
This is a minor refactoring of the code as a workaround discovered in #748 by moving the default operator usage outside the guard statement. This would enable developers to build apps that use the APIPlugin with the Model-to-GraphQLRequest builders on Swift 5.3 while we continue to investigate the issue

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@drochetti drochetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chatted offline about the impact and tests done, so it lgtm! 🚀

@lawmicha lawmicha merged commit 723f8a2 into main Sep 2, 2020
@lawmicha lawmicha deleted the fix/xcode-12 branch September 2, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants