Skip to content

Commit 3e91498

Browse files
authored
Added missing pullSecrets & pullPolicy (#293)
Signed-off-by: Nick Fisher <[email protected]> Description of changes: The helm chart's values.yaml files have the ability to set `pullPolicy` & `pullSecrets`, but the deployment.yaml does not contain the proper blocks to render the settings. This PR adds both of those. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 930850f commit 3e91498

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

templates/helm/templates/deployment.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,12 @@ spec:
3333
{{- end }}
3434
spec:
3535
serviceAccountName: {{ include "service-account.name" . }}
36+
{{- if .Values.image.pullSecrets }}
37+
imagePullSecrets:
38+
{{- range .Values.image.pullSecrets }}
39+
- name: {{ . }}
40+
{{- end }}
41+
{{- end }}
3642
containers:
3743
- command:
3844
- ./bin/controller
@@ -50,6 +56,7 @@ spec:
5056
- --watch-namespace
5157
- "$(ACK_WATCH_NAMESPACE)"
5258
image: {{ .Values.image.repository }}:{{ .Values.image.tag }}
59+
imagePullPolicy: {{ .Values.image.pullPolicy }}
5360
name: controller
5461
ports:
5562
- name: http

0 commit comments

Comments
 (0)