sdkDelete does not delete replicas

Author: rushmash91

Diff for: apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,7 +1,7 @@
 ack_generate_info:
-  build_date: "2025-03-24T15:20:40Z"
+  build_date: "2025-03-27T17:32:01Z"
   build_hash: 3722729cebe6d3c03c7e442655ef0846f91566a2
-  go_version: go1.24.0
+  go_version: go1.24.1
   version: v0.43.2-7-g3722729
 api_directory_checksum: cb49386ebd7bb50e2521072a76262c72b9dbd285
 api_version: v1alpha1

Diff for: pkg/resource/table/hooks.go

@@ -236,7 +236,7 @@ func (rm *resourceManager) customUpdateTable(
 		case delta.DifferentAt("Spec.TableReplicas"):
 			// Enabling replicas required streams enabled and StreamViewType to be NEW_AND_OLD_IMAGES
 			// Version 2019.11.21  TableUpdate API requirement
- 			if !hasStreamSpecificationWithNewAndOldImages(desired) {
+			if !hasStreamSpecificationWithNewAndOldImages(desired) {
 				msg := "table must have DynamoDB Streams enabled with StreamViewType set to NEW_AND_OLD_IMAGES for replica updates"
 				rlog.Debug(msg)
 				return nil, ackerr.NewTerminalError(errors.New(msg))

Diff for: pkg/resource/table/sdk.go

@@ -4,19 +4,3 @@
 	if isTableUpdating(r) {
 		return nil, requeueWaitWhileUpdating
 	}
-
-	// If there are replicas, we need to remove them before deleting the table
-	if len(r.ko.Spec.TableReplicas) > 0 {
-		desired := &resource{
-			ko: r.ko.DeepCopy(),
-		}
-		desired.ko.Spec.TableReplicas = nil
-
-		err := rm.syncReplicas(ctx, r, desired)
-		if err != nil {
-			return nil, err
-		}
-		// Requeue to wait for replica removal to complete before attempting table deletion
-		// When syncReplicas returns an error other than requeue
-		return r, requeueWaitWhileDeleting
-	}

Diff for: templates/hooks/table/sdk_delete_pre_build_request.go.tpl

@@ -53,7 +53,7 @@
 	} else {
 		ko.Spec.BillingMode = aws.String("PROVISIONED")
 	}
-	setTableReplicas(r, resp.Table.Replicas)
+	setTableReplicas(ko, resp.Table.Replicas)
 	if isTableCreating(&resource{ko}) {
 		return &resource{ko}, requeueWaitWhileCreating
 	}