Nit changes before release

Author: michaelhtm

pkg/resource/table/hooks.go

@@ -611,8 +611,10 @@ func customPreCompare(
 		a.ko.Spec.DeletionProtectionEnabled = aws.Bool(false)
 	}
 
-	if a.ko.Spec.ContributorInsights == nil && b.ko.Spec.ContributorInsights != nil &&
-		*b.ko.Spec.ContributorInsights == string(svcsdktypes.ContributorInsightsActionDisable) {
+	// Making this field a no-op if user does not set it.
+	// This will ensure controller does not act on this field
+	// if user is unaware of it.
+	if a.ko.Spec.ContributorInsights == nil {
 		a.ko.Spec.ContributorInsights = b.ko.Spec.ContributorInsights
 	}
 }

test/e2e/tests/test_table.py

@@ -29,7 +29,7 @@
 from e2e.replacement_values import REPLACEMENT_VALUES
 
 RESOURCE_PLURAL = "tables"
-
+CREATE_WAIT_AFTER_SECONDS = 30
 DELETE_WAIT_AFTER_SECONDS = 15
 MODIFY_WAIT_AFTER_SECONDS = 90
 
@@ -71,6 +71,8 @@ def create_table(name: str, resource_template):
         name, namespace="default",
     )
 
+    time.sleep(CREATE_WAIT_AFTER_SECONDS)
+
     # Create table
     k8s.create_custom_resource(table_reference, resource_data)
     table_resource = k8s.wait_resource_consumed_by_controller(table_reference)

test/e2e/tests/test_table_replicas.py

@@ -29,7 +29,7 @@
 from acktest.k8s import condition
 
 RESOURCE_PLURAL = "tables"
-
+CREATE_WAIT_AFTER_SECONDS = 30
 DELETE_WAIT_AFTER_SECONDS = 30
 MODIFY_WAIT_AFTER_SECONDS = 600
 REPLICA_WAIT_AFTER_SECONDS = 600
@@ -113,6 +113,7 @@ def create_table_with_invalid_replicas(name: str):
     )
     logging.debug(resource_data)
 
+    time.sleep(CREATE_WAIT_AFTER_SECONDS)
     # Create the k8s resource
     ref = k8s.CustomResourceReference(
         CRD_GROUP, CRD_VERSION, RESOURCE_PLURAL,