Fix flowlog crash

While creating FlowLog, if logDestnation does not exist then
CreateFlowLogsWithContext does not return the error. However,
Unsuccessful field in the response is set. FlowLog is not created in
aws. Due to this, controller crashes while accessing the flow log id
from the response (resp.FlowLogIds[0]).
Fixing the issue by checking if FlowLogIds has valid length before
accessing it.

Author: Nishant Burte

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,8 +1,8 @@
 ack_generate_info:
-  build_date: "2023-09-18T23:03:44Z"
-  build_hash: 892f29d00a4c4ad21a2fa32919921de18190979d
-  go_version: go1.20.3
-  version: v0.27.1
+  build_date: "2023-10-26T21:28:28Z"
+  build_hash: ca2060387b6ffb66a3c231929cc1243ab5d5f905
+  go_version: go1.21.1
+  version: v0.27.1-3-gca20603
 api_directory_checksum: 6e2d850d97f2f72db31c9bef522eca4ab95b3fcd
 api_version: v1alpha1
 aws_sdk_go_version: v1.44.93

config/controller/kustomization.yaml

@@ -6,4 +6,4 @@ kind: Kustomization
 images:
 - name: controller
   newName: public.ecr.aws/aws-controllers-k8s/ec2-controller
-  newTag: 1.0.7
+  newTag: 1.0.8

helm/Chart.yaml

@@ -1,8 +1,8 @@
 apiVersion: v1
 name: ec2-chart
 description: A Helm chart for the ACK service controller for Amazon Elastic Cloud Compute (EC2)
-version: 1.0.7
-appVersion: 1.0.7
+version: 1.0.8
+appVersion: 1.0.8
 home: https://github.com/aws-controllers-k8s/ec2-controller
 icon: https://raw.githubusercontent.com/aws/eks-charts/master/docs/logo/aws.png
 sources:

helm/templates/NOTES.txt

@@ -1,5 +1,5 @@
 {{ .Chart.Name }} has been installed.
-This chart deploys "public.ecr.aws/aws-controllers-k8s/ec2-controller:1.0.7".
+This chart deploys "public.ecr.aws/aws-controllers-k8s/ec2-controller:1.0.8".
 
 Check its status by running:
   kubectl --namespace {{ .Release.Namespace }} get pods -l "app.kubernetes.io/instance={{ .Release.Name }}"

helm/templates/deployment.yaml

@@ -123,7 +123,7 @@ spec:
             readOnly: true
         {{- end }}
         {{- if .Values.deployment.extraVolumeMounts -}}
-          {{ toYaml .Values.deployment.extraVolumeMounts | nindent 12 }}
+          {{ toYaml .Values.deployment.extraVolumeMounts | nindent 10 }}
         {{- end }}
         securityContext:
           allowPrivilegeEscalation: false
@@ -151,11 +151,11 @@ spec:
       hostNetwork: {{ .Values.deployment.hostNetwork }}
       dnsPolicy: {{ .Values.deployment.dnsPolicy }}
       volumes:
-      {{- if .Values.aws.credentials.secretName -}}
+      {{- if .Values.aws.credentials.secretName }}
         - name: {{ .Values.aws.credentials.secretName }}
           secret:
             secretName: {{ .Values.aws.credentials.secretName }}
-      {{ end -}}
+      {{- end }}
 {{- if .Values.deployment.extraVolumes }}
 {{ toYaml .Values.deployment.extraVolumes | indent 8}}
 {{- end }}

helm/values.yaml

@@ -4,7 +4,7 @@
 
 image:
   repository: public.ecr.aws/aws-controllers-k8s/ec2-controller
-  tag: 1.0.7
+  tag: 1.0.8
   pullPolicy: IfNotPresent
   pullSecrets: []
 

pkg/resource/flow_log/sdk.go

@@ -1,3 +1,3 @@
-    if resp.FlowLogIds[0] != nil {
+    if len(resp.FlowLogIds) > 0 && resp.FlowLogIds[0] != nil {
 		ko.Status.FlowLogID = resp.FlowLogIds[0]
 	}