Fix flowlog crash

Nishant Burte · Nishant Burte · commit 5c94e477b76f · 2023-10-30T09:49:33.000-07:00
While creating FlowLog, if logDestnation does not exist then
CreateFlowLogsWithContext does not return the error. However,
Unsuccessful field in the response is set. FlowLog is not created in
aws. Due to this, controller crashes while accessing the flow log id
from the response (resp.FlowLogIds[0]).
Fixing the issue by checking if FlowLogIds has valid length before
accessing it.
diff --git a/apis/v1alpha1/ack-generate-metadata.yaml b/apis/v1alpha1/ack-generate-metadata.yaml
@@ -1,7 +1,7 @@
 ack_generate_info:
-  build_date: "2023-09-18T23:03:44Z"
+  build_date: "2023-10-26T21:49:39Z"
   build_hash: 892f29d00a4c4ad21a2fa32919921de18190979d
-  go_version: go1.20.3
+  go_version: go1.21.1
   version: v0.27.1
 api_directory_checksum: 6e2d850d97f2f72db31c9bef522eca4ab95b3fcd
 api_version: v1alpha1
diff --git a/pkg/resource/flow_log/sdk.go b/pkg/resource/flow_log/sdk.go
diff --git a/templates/hooks/flow_log/sdk_create_post_set_output.go.tpl b/templates/hooks/flow_log/sdk_create_post_set_output.go.tpl
@@ -1,3 +1,3 @@
-    if resp.FlowLogIds[0] != nil {
+    if len(resp.FlowLogIds) > 0 && resp.FlowLogIds[0] != nil {
 		ko.Status.FlowLogID = resp.FlowLogIds[0]
 	}

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`		`- if resp.FlowLogIds[0] != nil {`
	`1`	`+ if len(resp.FlowLogIds) > 0 && resp.FlowLogIds[0] != nil {`
`2`	`2`	`ko.Status.FlowLogID = resp.FlowLogIds[0]`
`3`	`3`	`}`