Add test for CustomerPreCompare

Author: Gereon Frey

go.mod

@@ -10,6 +10,7 @@ require (
 	github.com/go-logr/logr v1.4.2
 	github.com/samber/lo v1.37.0
 	github.com/spf13/pflag v1.0.5
+	github.com/stretchr/testify v1.9.0
 	k8s.io/api v0.31.0
 	k8s.io/apimachinery v0.31.0
 	k8s.io/client-go v0.31.0
@@ -48,6 +49,7 @@ require (
 	github.com/modern-go/reflect2 v1.0.2 // indirect
 	github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
 	github.com/pkg/errors v0.9.1 // indirect
+	github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
 	github.com/prometheus/client_golang v1.19.1 // indirect
 	github.com/prometheus/client_model v0.6.1 // indirect
 	github.com/prometheus/common v0.55.0 // indirect

pkg/resource/route_table/hooks_test.go

@@ -0,0 +1,101 @@
+package route_table
+
+import (
+	"testing"
+
+	svcapitypes "github.com/aws-controllers-k8s/ec2-controller/apis/v1alpha1"
+	ackcompare "github.com/aws-controllers-k8s/runtime/pkg/compare"
+	"github.com/aws/aws-sdk-go/aws"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestCustomerPreCompare(t *testing.T) {
+	type Routes []*svcapitypes.CreateRouteInput
+
+	peeringRoute := func(pcxID string, cidr string) *svcapitypes.CreateRouteInput {
+		return &svcapitypes.CreateRouteInput{
+			DestinationCIDRBlock:   aws.String(cidr),
+			VPCPeeringConnectionID: aws.String(pcxID),
+		}
+	}
+
+	createRouteTableTestResource := func(routes []*svcapitypes.CreateRouteInput) *resource {
+		return &resource{
+			ko: &svcapitypes.RouteTable{
+				Spec: svcapitypes.RouteTableSpec{
+					Routes: routes,
+				},
+			},
+		}
+	}
+
+	tt := []struct {
+		id            string
+		desiredRoutes Routes
+		latestRoutes  Routes
+		toAdd         Routes
+		toDelete      Routes
+	}{
+		{"all identical",
+			Routes{peeringRoute("pcx-123", "172.30.1.0/24")},
+			Routes{peeringRoute("pcx-123", "172.30.1.0/24")},
+			nil, nil,
+		},
+		{"add route",
+			Routes{peeringRoute("pcx-123", "172.30.1.0/24")},
+			nil,
+			Routes{peeringRoute("pcx-123", "172.30.1.0/24")},
+			nil,
+		},
+		{"delete route",
+			nil,
+			Routes{peeringRoute("pcx-123", "172.30.1.0/24")},
+			nil,
+			Routes{peeringRoute("pcx-123", "172.30.1.0/24")},
+		},
+		{"keep one delete one",
+			Routes{peeringRoute("pcx-123", "172.30.1.0/24")},
+			Routes{peeringRoute("pcx-123", "172.30.1.0/24"), peeringRoute("pcx-123", "172.30.2.0/24")},
+			nil,
+			Routes{peeringRoute("pcx-123", "172.30.2.0/24")},
+		},
+		{"keep one add one",
+			Routes{peeringRoute("pcx-123", "172.30.1.0/24"), peeringRoute("pcx-123", "172.30.2.0/24")},
+			Routes{peeringRoute("pcx-123", "172.30.1.0/24")},
+			Routes{peeringRoute("pcx-123", "172.30.2.0/24")},
+			nil,
+		},
+		{"keep one add one delete one",
+			Routes{peeringRoute("pcx-123", "172.30.1.0/24"), peeringRoute("pcx-123", "172.30.2.0/24")},
+			Routes{peeringRoute("pcx-123", "172.30.1.0/24"), peeringRoute("pcx-123", "172.30.3.0/24")},
+			Routes{peeringRoute("pcx-123", "172.30.2.0/24")},
+			Routes{peeringRoute("pcx-123", "172.30.3.0/24")},
+		},
+	}
+
+	for _, tti := range tt {
+		t.Run(tti.id, func(t *testing.T) {
+			delta := ackcompare.NewDelta()
+			a := createRouteTableTestResource(tti.desiredRoutes)
+			b := createRouteTableTestResource(tti.latestRoutes)
+			customPreCompare(delta, a, b)
+			if len(tti.toAdd) == 0 && len(tti.toDelete) == 0 {
+				assert.Equal(t, 0, len(delta.Differences))
+			} else {
+				diff := delta.Differences[0]
+				diffA := diff.A.([]*svcapitypes.CreateRouteInput)
+				diffB := diff.B.([]*svcapitypes.CreateRouteInput)
+				assert.True(t, diff.Path.Contains("Spec.Routes"))
+				require.Equal(t, len(tti.toAdd), len(diffA))
+				require.Equal(t, len(tti.toDelete), len(diffB))
+				for i := range tti.toAdd {
+					assert.Equal(t, tti.toAdd[i], diffA[i])
+				}
+				for i := range tti.toDelete {
+					assert.Equal(t, tti.toDelete[i], diffB[i])
+				}
+			}
+		})
+	}
+}