Skip to content

Commit 1d3c41d

Browse files
authored
fix: late initialize volumeInSizeGB field (#190)
Issue #, if available: aws-controllers-k8s/community#1628 Description of changes: Adds volumeInSizeGB as a late initialized field in NotebookInstance. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 69fd17e commit 1d3c41d

File tree

4 files changed

+17
-5
lines changed

4 files changed

+17
-5
lines changed
+2-2
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
ack_generate_info:
2-
build_date: "2023-01-10T19:11:16Z"
2+
build_date: "2023-01-12T17:32:55Z"
33
build_hash: 12246c7da82841b351ec7a9e1f139f9338f2784b
44
go_version: go1.17.13
55
version: v0.21.0
66
api_directory_checksum: 48886052888c7166740636bc128afdb53d05a4cb
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.44.117
99
generator_config_info:
10-
file_checksum: 1c2565c8be351e2db5832b707691a43bf3d38555
10+
file_checksum: 0dbded7103f1cdd041678e22ac0fffcc6ec12ff1
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation

apis/v1alpha1/generator.yaml

+4-1
Original file line numberDiff line numberDiff line change
@@ -688,7 +688,10 @@ resources:
688688
path: FailureReason
689689
Tags:
690690
compare:
691-
is_ignored: true
691+
is_ignored: true
692+
VolumeSizeInGB:
693+
late_initialize:
694+
min_backoff_seconds: 5
692695
ModelPackageGroup:
693696
exceptions:
694697
errors:

generator.yaml

+4-1
Original file line numberDiff line numberDiff line change
@@ -688,7 +688,10 @@ resources:
688688
path: FailureReason
689689
Tags:
690690
compare:
691-
is_ignored: true
691+
is_ignored: true
692+
VolumeSizeInGB:
693+
late_initialize:
694+
min_backoff_seconds: 5
692695
ModelPackageGroup:
693696
exceptions:
694697
errors:

pkg/resource/notebook_instance/manager.go

+7-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)