Skip to content

Commit e5bda0f

Browse files
authored
remove getImmutableFieldChanges references (#72)
fix aws-controllers-k8s/code-generator#565 Description of changes: Remove getImmutableFieldChanges from hooks to support cel immutability field `Name` immutability test removed for resource `Topic` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent ef6edb7 commit e5bda0f

File tree

2 files changed

+0
-18
lines changed

2 files changed

+0
-18
lines changed

Diff for: pkg/resource/topic/hooks.go

-5
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import (
1717
"context"
1818
"errors"
1919
"fmt"
20-
"strings"
2120

2221
ackv1alpha1 "github.com/aws-controllers-k8s/runtime/apis/core/v1alpha1"
2322
ackcompare "github.com/aws-controllers-k8s/runtime/pkg/compare"
@@ -65,10 +64,6 @@ func (rm *resourceManager) customUpdate(
6564
defer func() {
6665
exit(err)
6766
}()
68-
if immutableFieldChanges := rm.getImmutableFieldChanges(delta); len(immutableFieldChanges) > 0 {
69-
msg := fmt.Sprintf("Immutable Spec fields have been modified: %s", strings.Join(immutableFieldChanges, ","))
70-
return nil, ackerr.NewTerminalError(fmt.Errorf(msg))
71-
}
7267
if delta.DifferentAt("Spec.Tags") {
7368
if err := rm.syncTags(ctx, desired, latest); err != nil {
7469
return nil, err

Diff for: test/e2e/tests/test_topic.py

-13
Original file line numberDiff line numberDiff line change
@@ -177,19 +177,6 @@ def test_crud(self, simple_topic):
177177
expect_after_update_tags, latest_tags,
178178
)
179179

180-
updates = {
181-
"spec": {"name": "my-simple-topic-edited"}
182-
}
183-
k8s.patch_custom_resource(ref, updates)
184-
time.sleep(MODIFY_WAIT_AFTER_SECONDS)
185-
k8s.wait_resource_consumed_by_controller(ref)
186-
condition.assert_type_status(ref, condition.CONDITION_TYPE_TERMINAL)
187-
188-
expected_msg = "Immutable Spec fields have been modified: Name"
189-
terminal_condition = k8s.get_resource_condition(ref, condition.CONDITION_TYPE_TERMINAL)
190-
# The name is immutable, testing if we get a terminal error
191-
assert expected_msg in terminal_condition['message']
192-
193180
def test_crud_fifo(self, fifo_topic):
194181
ref, res = fifo_topic
195182

0 commit comments

Comments
 (0)