Skip to content

chore - Update pr template #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Feb 7, 2023

Issue number:N/A

Summary

Remove bold from Issue Number, so that it passes label_related_issue.js regex expression.

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Remove bold from Issue Number, so that it passes label_related_issue.js regex expression.
@auto-assign auto-assign bot requested a review from sliedig February 7, 2023 12:55
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions github-actions bot added do-not-merge PRs that are blocked for varying reasons need-issue PR is missing a related issue for tracking change labels Feb 7, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 56.29% // Head: 56.35% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (ad5be3f) compared to base (3d26f5b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #194      +/-   ##
===========================================
+ Coverage    56.29%   56.35%   +0.05%     
===========================================
  Files           41       41              
  Lines         1778     1778              
===========================================
+ Hits          1001     1002       +1     
+ Misses         777      776       -1     
Flag Coverage Δ
unittests 56.35% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...da.Powertools.Logging/Internal/PowertoolsLogger.cs 90.96% <0.00%> (+0.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sliedig sliedig merged commit 642f63a into aws-powertools:develop Feb 8, 2023
@sliedig sliedig removed the do-not-merge PRs that are blocked for varying reasons label Feb 8, 2023
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

@awslabs/aws-lambda-powertools-net No related issues found. Please ensure 'pending-release' label is applied before releasing.

@sliedig sliedig added pending-release Fix or implementation already in dev waiting to be released and removed need-issue PR is missing a related issue for tracking change labels Feb 8, 2023
@hjgraca hjgraca deleted the patch-1 branch April 12, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-release Fix or implementation already in dev waiting to be released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants