feat: Add ClearAllDimensions Method #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he global DefaultDimensions and Instead checking if the passed variable is empty if so return so we don't delete the default, other wise set the Default to the passed ones
2 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #293 +/- ##
===========================================
+ Coverage 69.09% 69.25% +0.16%
===========================================
Files 79 79
Lines 3433 3448 +15
===========================================
+ Hits 2372 2388 +16
+ Misses 1061 1060 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
@glynn1211 thank you for submitting a PR. |
…Dimensions from the clear method
hjgraca
approved these changes
Jun 10, 2023
|
|
||
| var configurations = new Mock<IPowertoolsConfigurations>(); | ||
|
|
||
| var logger = new Metrics( |
There was a problem hiding this comment.
Something we need to change later in all Metrics tests, the variable name should be metrics and not logger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #292
Summary
Add a method to allow users to clear the existing Dimensions.
Changes
Added a ClearAllDimensions Method that will clear all dimensions which removes the default set "Service"
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.