Skip to content

docs: Parameters example #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 27, 2023
Merged

Conversation

amirkaws
Copy link
Contributor

Issue number: #286

Summary

Changes

Introduce an example for Parameters utility.

User experience

This changes added an example solution on how to use Parameters utility

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested a review from sliedig June 14, 2023 15:29
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 14, 2023
@amirkaws amirkaws requested a review from hjgraca June 14, 2023 15:31
Copy link
Contributor

@sliedig sliedig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amirkaws just a couple of comments, nothing major. Just need to provide a bit more context for the demo

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.14 🎉

Comparison is base (0a920b0) 69.11% compared to head (a962e1f) 69.25%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #298      +/-   ##
===========================================
+ Coverage    69.11%   69.25%   +0.14%     
===========================================
  Files           79       79              
  Lines         3448     3448              
===========================================
+ Hits          2383     2388       +5     
+ Misses        1065     1060       -5     
Flag Coverage Δ
unittests 69.25% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hjgraca hjgraca linked an issue Jun 20, 2023 that may be closed by this pull request
1 task
@boring-cyborg boring-cyborg bot added the internal Maintenance changes label Jun 26, 2023
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 26, 2023
@amirkaws
Copy link
Contributor Author

@amirkaws just a couple of comments, nothing major. Just need to provide a bit more context for the demo

@sliedig fyi, I have added a section in readme for the additional resources are created and where to find them, also addressed other comments.

@hjgraca hjgraca merged commit 368b099 into aws-powertools:develop Jun 27, 2023
@amirkaws amirkaws deleted the parameters-example branch June 27, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/parameters documentation Improvements or additions to documentation internal Maintenance changes size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Add Parameters Example
4 participants