Skip to content

chore: add e2e tests for idempotency method #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Nov 6, 2023

Please provide the issue number

Issue number: #512

Summary

We were missing a test for the E2E journey when decorating a method and not the handler

Changes

Add missing E2E tests

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested review from amirkaws and sliedig November 6, 2023 09:37
@boring-cyborg boring-cyborg bot added the tests label Nov 6, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 6, 2023
@hjgraca hjgraca linked an issue Nov 6, 2023 that may be closed by this pull request
1 task
@github-actions github-actions bot added the internal Maintenance changes label Nov 6, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe4ef8b) 72.21% compared to head (a87e492) 72.11%.
Report is 13 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #513      +/-   ##
===========================================
- Coverage    72.21%   72.11%   -0.11%     
===========================================
  Files          101      101              
  Lines         4064     4106      +42     
  Branches       413      418       +5     
===========================================
+ Hits          2935     2961      +26     
- Misses        1017     1026       +9     
- Partials       112      119       +7     
Flag Coverage Δ
unittests 72.11% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amirkaws amirkaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjgraca hjgraca merged commit c7fe319 into aws-powertools:develop Nov 21, 2023
@hjgraca hjgraca deleted the idempotency-method-e2e-test branch November 21, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Add E2E test for Idempotency with method decorator
3 participants