Skip to content

chore: dotnet 8 support #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 24, 2024
Merged

chore: dotnet 8 support #542

merged 13 commits into from
Jan 24, 2024

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Jan 17, 2024

Please provide the issue number

Issue number: #212

Summary

Add support for dotnet 8

  • Github Build
  • Target Frameworks

Changes

  • Update build workflow
  • Add to projects target framework dotnet8.0

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested review from amirkaws and sliedig January 17, 2024 16:17
@boring-cyborg boring-cyborg bot added github-actions Changes in GitHub workflows internal Maintenance changes tests labels Jan 17, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 17, 2024
@hjgraca hjgraca mentioned this pull request Jan 17, 2024
Closed
7 tasks
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 17, 2024
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 17, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

amirkaws
amirkaws approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@amirkaws amirkaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjgraca hjgraca merged commit 43a50f1 into aws-powertools:develop Jan 24, 2024
@hjgraca hjgraca mentioned this pull request Feb 21, 2024
Open
2 tasks
@hjgraca hjgraca deleted the dotnet8-support branch March 20, 2024 14:46
@hjgraca hjgraca restored the dotnet8-support branch March 20, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirkaws amirkaws amirkaws approved these changes

@sliedig sliedig Awaiting requested review from sliedig

Assignees
No one assigned
Labels
github-actions Changes in GitHub workflows internal Maintenance changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjgraca @amirkaws