Skip to content

chore: Remove the build target step in DIrectory.Build.targets to include JMESPath in the Idempotency project #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Jul 29, 2024

Please provide the issue number

Issue number: #626

Summary

Changes

Remove the build target step in DIrectory.Build.targets to include JMESPath in the Idempotency project.
Contrary to Common this package is not used anywhere else and thus not having version clashes.

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested review from amirkaws and sliedig July 29, 2024 11:39
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 29, 2024
@github-actions github-actions bot added the internal Maintenance changes label Jul 29, 2024
@hjgraca hjgraca changed the title chore: Remove the build target step in DIrectory.Build.targets to include JM… chore: Remove the build target step in DIrectory.Build.targets to include JMESPath in the Idempotency project Jul 29, 2024
Copy link

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.41%. Comparing base (aef100c) to head (1c775a3).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #627      +/-   ##
===========================================
- Coverage    72.74%   72.41%   -0.34%     
===========================================
  Files          190      190              
  Lines         7874     7874              
  Branches       850      850              
===========================================
- Hits          5728     5702      -26     
- Misses        1857     1878      +21     
- Partials       289      294       +5     
Flag Coverage Δ
unittests 72.41% <ø> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amirkaws amirkaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjgraca hjgraca merged commit 00d7c76 into aws-powertools:develop Aug 21, 2024
11 of 12 checks passed
@hjgraca hjgraca deleted the fix-idempotency-jmespath-dependency branch August 21, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants