chore: AOT support for Idempotency #653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dempotencySerializationContext.cs and Serializer. Update code to use both serializers
pull-request-size
bot
added
the
size/XL
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #653 +/- ##
===========================================
+ Coverage 73.42% 73.43% +0.01%
===========================================
Files 203 203
Lines 8173 8181 +8
Branches 877 878 +1
===========================================
+ Hits 6001 6008 +7
- Misses 1880 1881 +1
Partials 292 292
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
…a-dotnet into aot(idempotency|jmespath)-aot-support
…a-dotnet into aot(idempotency|jmespath)-aot-support
- Implemented AOT-Function with idempotency configuration and handler. - Created AOT-FunctionHandlerTest and AOT-FunctionPayloadSubsetTest projects. - Updated FunctionTests to include AOT-specific tests for idempotency. - Enhanced documentation to include AOT support details.
…a-dotnet into aot(idempotency|jmespath)-aot-support
…pport' into aot(idempotency|jmespath)-aot-support
boring-cyborg
bot
added
the
documentation
pull-request-size
bot
added
size/XXL
|
leandrodamascena
approved these changes
Feb 5, 2025
Comment on lines
+125
to
+127
| #if NET8_0_OR_GREATER | ||
| [Obsolete("Idempotency uses MD5 and does not support other hash algorithms.")] | ||
| #endif |
There was a problem hiding this comment.
Nice! I think make sense we add this in other runtime because we don't allow customer to bring others hash algorithm.
This was referenced Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #212
Summary
Changes
Support for AOT in Idempotency and JMESPath.
Done:
User experience
For serlializing client types inside Idempotency we now have a new method
WithJsonSerializationContext.This method receives the client JsonSerializationContext
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.