Skip to content

chore: Exception logging to include inner exceptions #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Jan 6, 2025

Please provide the issue number

Issue number: #680

Summary

Changes

This pull request focuses on enhancing the logging functionality by improving how exceptions, particularly inner exceptions, are handled and logged. The key changes include refactoring the exception writing logic, updating the property extraction to include inner exceptions, and adding new tests to verify these changes.

Enhancements to exception handling and logging:

Tests for improved exception logging:

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested review from amirkaws and sliedig January 6, 2025 12:24
@boring-cyborg boring-cyborg bot added area/logging Core logging utility tests labels Jan 6, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 6, 2025
@github-actions github-actions bot added the internal Maintenance changes label Jan 6, 2025
Copy link

sonarqubecloud bot commented Jan 6, 2025

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 64.28571% with 10 lines in your changes missing coverage. Please review.

Project coverage is 73.34%. Comparing base (46d5b86) to head (c99100e).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
....Logging/Internal/Converters/ExceptionConverter.cs 62.96% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #681      +/-   ##
===========================================
+ Coverage    73.29%   73.34%   +0.05%     
===========================================
  Files          200      200              
  Lines         8103     8112       +9     
  Branches       871      872       +1     
===========================================
+ Hits          5939     5950      +11     
+ Misses        1875     1874       -1     
+ Partials       289      288       -1     
Flag Coverage Δ
unittests 73.34% <64.28%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leandrodamascena leandrodamascena self-requested a review January 9, 2025 12:48
@hjgraca hjgraca merged commit b32961e into aws-powertools:develop Jan 13, 2025
9 of 10 checks passed
@hjgraca hjgraca deleted the feat(logging)-inner-exception branch January 14, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging Core logging utility internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants