-
Notifications
You must be signed in to change notification settings - Fork 26
chore: Add end-to-end tests #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #684 +/- ##
===========================================
- Coverage 73.34% 73.22% -0.13%
===========================================
Files 200 200
Lines 8112 8112
Branches 872 872
===========================================
- Hits 5950 5940 -10
- Misses 1874 1880 +6
- Partials 288 292 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…a-dotnet into feature/e2etests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hjgraca I left some comments!
Thanks a lot for working on this.
run-tests: | ||
uses: ./.github/workflows/e2e-tests.yml | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move it to e2etests wokflow and add run-tests
as a dependency in there.
uses: aws-actions/configure-aws-credentials@v2 | ||
with: | ||
role-to-assume: ${{ secrets.E2E_DEPLOY_ROLE }} | ||
aws-region: us-east-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this as secret to ease if we need to move between regions.
uses: actions/checkout@v4 | ||
|
||
- name: Configure AWS credentials | ||
uses: aws-actions/configure-aws-credentials@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a best practices, please put the sha256 that matches this version. Dependabot will bump it.
|
Issue number: #683
Summary
Changes
This pull request introduces several changes to the CI/CD workflows and the project structure to enhance the end-to-end (E2E) testing and deployment processes. The most important changes include the addition of new workflows for deploying and destroying E2E infrastructure, the creation of a new E2E test workflow, and updates to the solution file to include new projects and configurations.
CI/CD Workflows:
develop
branch and manual dispatch. (.github/workflows/e2e-infra-deploy.yml
).github/workflows/e2e-infra-destroy.yml
).github/workflows/e2e-tests.yml
)Project Structure:
libraries/AWS.Lambda.Powertools.sln
) [1] [2] [3]Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.