chore(parameters): remove parallel option due to timeout risk

Author: heitorlessa

Diff for: aws_lambda_powertools/utilities/parameters/ssm.py

@@ -1,9 +1,6 @@
 """
 AWS SSM Parameter retrieval and caching utility
 """
-import concurrent.futures
-import functools
-from concurrent.futures import Future
 from typing import TYPE_CHECKING, Any, Dict, Optional, Union, overload
 
 import boto3
@@ -356,7 +353,6 @@ def get_parameters_by_name(
     decrypt: bool = False,
     force_fetch: bool = False,
     max_age: int = DEFAULT_MAX_AGE_SECS,
-    parallel: bool = False,
 ) -> Dict[str, str]:
     ...
 
@@ -368,7 +364,6 @@ def get_parameters_by_name(
     decrypt: bool = False,
     force_fetch: bool = False,
     max_age: int = DEFAULT_MAX_AGE_SECS,
-    parallel: bool = False,
 ) -> Dict[str, bytes]:
     ...
 
@@ -380,7 +375,6 @@ def get_parameters_by_name(
     decrypt: bool = False,
     force_fetch: bool = False,
     max_age: int = DEFAULT_MAX_AGE_SECS,
-    parallel: bool = False,
 ) -> Dict[str, Dict[str, Any]]:
     ...
 
@@ -392,7 +386,6 @@ def get_parameters_by_name(
     decrypt: bool = False,
     force_fetch: bool = False,
     max_age: int = DEFAULT_MAX_AGE_SECS,
-    parallel: bool = False,
 ) -> Union[Dict[str, str], Dict[str, dict]]:
     ...
 
@@ -403,7 +396,6 @@ def get_parameters_by_name(
     decrypt: bool = False,
     force_fetch: bool = False,
     max_age: int = DEFAULT_MAX_AGE_SECS,
-    parallel: bool = False,
 ) -> Union[Dict[str, str], Dict[str, bytes], Dict[str, dict]]:
     """
     Retrieve multiple parameter values by name from AWS Systems Manager (SSM) Parameter Store
@@ -420,8 +412,6 @@ def get_parameters_by_name(
         Force update even before a cached item has expired, defaults to False
     max_age: int
         Maximum age of the cached value
-    sdk_options: dict, optional
-        Dictionary of options that will be passed to the Parameter Store get_parameter API call
 
     Raises
     ------
@@ -432,54 +422,24 @@ def get_parameters_by_name(
         When the parameter provider fails to transform a parameter value.
     """
 
-    # NOTE: Need a param for hard failure mode on parameter retrieval (asked feature request author)
-    # NOTE: Decide whether to leave multi-threaded option or not due to slower results (throttling+LWP cost)
+    # NOTE: Decided against using multi-thread due to single-thread outperforming in 128M and 1G + timeout risk
+    # see: https://github.com/awslabs/aws-lambda-powertools-python/issues/1040#issuecomment-1299954613
 
     ret: Dict[str, Any] = {}
-    future_to_param: Dict[Future, str] = {}
-
-    if parallel:
-        with concurrent.futures.ThreadPoolExecutor(max_workers=len(parameters)) as pool:
-            for parameter, options in parameters.items():
-                if isinstance(options, dict):
-                    transform = options.get("transform") or transform
-                    decrypt = options.get("decrypt") or decrypt
-                    max_age = options.get("max_age") or max_age
-                    force_fetch = options.get("force_fetch") or force_fetch
-
-                fetch_parameter_callable = functools.partial(
-                    get_parameter,
-                    name=parameter,
-                    transform=transform,
-                    decrypt=decrypt,
-                    max_age=max_age,
-                    force_fetch=force_fetch,
-                )
-
-                future = pool.submit(fetch_parameter_callable)
-                future_to_param[future] = parameter
-
-            for future in concurrent.futures.as_completed(future_to_param):
-                try:
-                    # "parameter": "future result"
-                    ret[future_to_param[future]] = future.result()
-                except Exception as exc:
-                    print(f"Uh oh, failed to fetch '{future_to_param[future]}': {exc}")
-
-    else:
-        for parameter, options in parameters.items():
-            if isinstance(options, dict):
-                transform = options.get("transform") or transform
-                decrypt = options.get("decrypt") or decrypt
-                max_age = options.get("max_age") or max_age
-                force_fetch = options.get("force_fetch") or force_fetch
-
-            ret[parameter] = get_parameter(
-                name=parameter,
-                transform=transform,
-                decrypt=decrypt,
-                max_age=max_age,
-                force_fetch=force_fetch,
-            )
+
+    for parameter, options in parameters.items():
+        if isinstance(options, dict):
+            transform = options.get("transform") or transform
+            decrypt = options.get("decrypt") or decrypt
+            max_age = options.get("max_age") or max_age
+            force_fetch = options.get("force_fetch") or force_fetch
+
+        ret[parameter] = get_parameter(
+            name=parameter,
+            transform=transform,
+            decrypt=decrypt,
+            max_age=max_age,
+            force_fetch=force_fetch,
+        )
 
     return ret

Diff for: tests/e2e/parameters/handlers/parameter_ssm_get_parameters_by_name.py

@@ -12,4 +12,4 @@ def lambda_handler(event: dict, context: LambdaContext) -> Dict[str, Any]:
     parameters_to_fetch: Dict[str, Any] = {param: {} for param in parameters_list}
 
     # response`{parameter:value}`
-    return get_parameters_by_name(parameters=parameters_to_fetch, max_age=0, parallel=True)
+    return get_parameters_by_name(parameters=parameters_to_fetch, max_age=0)