fix: comment out validators #118

Author: heitorlessa

aws_lambda_powertools/utilities/advanced_parser/schemas/dynamodb.py

@@ -1,7 +1,7 @@
 from datetime import date
 from typing import Any, Dict, List, Optional
 
-from pydantic import BaseModel, root_validator
+from pydantic import BaseModel
 from typing_extensions import Literal
 
 
@@ -14,15 +14,16 @@ class DynamoScheme(BaseModel):
     SizeBytes: int
     StreamViewType: Literal["NEW_AND_OLD_IMAGES", "KEYS_ONLY", "NEW_IMAGE", "OLD_IMAGE"]
 
+    # context on why it's commented: https://github.com/awslabs/aws-lambda-powertools-python/pull/118
     # since both images are optional, they can both be None. However, at least one must
     # exist in a legal schema of NEW_AND_OLD_IMAGES type
-    @root_validator
-    def check_one_image_exists(cls, values):
-        new_img, old_img = values.get("NewImage"), values.get("OldImage")
-        stream_type = values.get("StreamViewType")
-        if stream_type == "NEW_AND_OLD_IMAGES" and not new_img and not old_img:
-            raise TypeError("DynamoDB streams schema failed validation, missing both new & old stream images")
-        return values
+    # @root_validator
+    # def check_one_image_exists(cls, values): # noqa: E800
+    #     new_img, old_img = values.get("NewImage"), values.get("OldImage") # noqa: E800
+    #     stream_type = values.get("StreamViewType") # noqa: E800
+    #     if stream_type == "NEW_AND_OLD_IMAGES" and not new_img and not old_img: # noqa: E800
+    #         raise TypeError("DynamoDB streams schema failed validation, missing both new & old stream images") # noqa: E800,E501
+    #     return values # noqa: E800
 
 
 class UserIdentity(BaseModel):

aws_lambda_powertools/utilities/advanced_parser/schemas/sqs.py

@@ -1,8 +1,7 @@
-import re
 from datetime import datetime
 from typing import Dict, List, Optional
 
-from pydantic import BaseModel, root_validator, validator
+from pydantic import BaseModel
 from typing_extensions import Literal
 
 
@@ -24,28 +23,29 @@ class SqsMsgAttributeSchema(BaseModel):
     binaryListValues: List[str] = []
     dataType: str
 
+    # context on why it's commented: https://github.com/awslabs/aws-lambda-powertools-python/pull/118
     # Amazon SQS supports the logical data types String, Number, and Binary with optional custom data type
     # labels with the format .custom-data-type.
     # https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-message-metadata.html#sqs-message-attributes
-    @validator("dataType")
-    def valid_type(cls, v):  # noqa: VNE001
-        pattern = re.compile("Number.*|String.*|Binary.*")
-        if not pattern.match(v):
-            raise TypeError("data type is invalid")
-        return v
-
-    # validate that dataType and value are not None and match
-    @root_validator
-    def check_str_and_binary_values(cls, values):
-        binary_val, str_val = values.get("binaryValue", ""), values.get("stringValue", "")
-        data_type = values.get("dataType")
-        if not str_val and not binary_val:
-            raise TypeError("both binaryValue and stringValue are missing")
-        if data_type.startswith("Binary") and not binary_val:
-            raise TypeError("binaryValue is missing")
-        if (data_type.startswith("String") or data_type.startswith("Number")) and not str_val:
-            raise TypeError("stringValue is missing")
-        return values
+    # @validator("dataType")
+    # def valid_type(cls, v):  # noqa: VNE001,E800 # noqa: E800
+    #     pattern = re.compile("Number.*|String.*|Binary.*") # noqa: E800
+    #     if not pattern.match(v): # noqa: E800
+    #         raise TypeError("data type is invalid") # noqa: E800
+    #     return v # noqa: E800
+    #
+    # # validate that dataType and value are not None and match
+    # @root_validator
+    # def check_str_and_binary_values(cls, values): # noqa: E800
+    #     binary_val, str_val = values.get("binaryValue", ""), values.get("stringValue", "") # noqa: E800
+    #     data_type = values.get("dataType") # noqa: E800
+    #     if not str_val and not binary_val: # noqa: E800
+    #         raise TypeError("both binaryValue and stringValue are missing") # noqa: E800
+    #     if data_type.startswith("Binary") and not binary_val: # noqa: E800
+    #         raise TypeError("binaryValue is missing") # noqa: E800
+    #     if (data_type.startswith("String") or data_type.startswith("Number")) and not str_val: # noqa: E800
+    #         raise TypeError("stringValue is missing") # noqa: E800
+    #     return values # noqa: E800
 
 
 class SqsRecordSchema(BaseModel):