Skip to content

Commit f5c0bf4

Browse files
committed
chore: rename cfn_template to asset_manifest to fix misunderstanding
1 parent 56ae2be commit f5c0bf4

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

tests/e2e/utils/asset.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -57,27 +57,27 @@ def _resolve_bucket_name(self) -> str:
5757

5858
class Assets:
5959
def __init__(
60-
self, cfn_template: Path, account_id: str, region: str, boto3_client: Optional[S3Client] = None
60+
self, asset_manifest: Path, account_id: str, region: str, boto3_client: Optional[S3Client] = None
6161
) -> None:
6262
"""CDK Assets logic to find each asset, compress, and upload
6363
6464
Parameters
6565
----------
66-
cfn_template : Path
67-
CloudFormation template synthesized (self.__synthesize)
66+
asset_manifest : Path
67+
Asset manifest JSON file (self.__synthesize)
6868
account_id : str
6969
AWS Account ID
7070
region : str
7171
AWS Region
7272
boto3_client : Optional[S3Client], optional
7373
S3 client instance for asset operations, by default None
7474
"""
75-
self.template = cfn_template
75+
self.asset_manifest = asset_manifest
7676
self.account_id = account_id
7777
self.region = region
7878
self.s3 = boto3_client or boto3.client("s3")
7979
self.assets = self._find_assets_from_template()
80-
self.assets_location = str(self.template.parent)
80+
self.assets_location = str(self.asset_manifest.parent)
8181

8282
def upload(self):
8383
"""Drop-in replacement for cdk-assets package s3 upload part.
@@ -101,7 +101,7 @@ def upload(self):
101101
logger.debug("Successfully uploaded")
102102

103103
def _find_assets_from_template(self) -> List[Asset]:
104-
data = json.loads(self.template.read_text())
104+
data = json.loads(self.asset_manifest.read_text())
105105
template = TemplateAssembly(**data)
106106
return [
107107
Asset(config=asset_config, account_id=self.account_id, region=self.region)

tests/e2e/utils/infrastructure.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ def deploy(self) -> Dict[str, str]:
306306
CloudFormation Stack Outputs with output key and value
307307
"""
308308
template, asset_manifest_file = self._synthesize()
309-
assets = Assets(cfn_template=asset_manifest_file, account_id=self.account_id, region=self.region)
309+
assets = Assets(asset_manifest=asset_manifest_file, account_id=self.account_id, region=self.region)
310310
assets.upload()
311311
return self._deploy_stack(self.stack_name, template)
312312

0 commit comments

Comments
 (0)