Skip to content

Support optional YAML per AppConfigStore instance for feature_flags #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
whardier opened this issue Sep 22, 2021 · 2 comments
Closed

Support optional YAML per AppConfigStore instance for feature_flags #1179

whardier opened this issue Sep 22, 2021 · 2 comments

Comments

@whardier
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Alter feature_flags to use default transform JSON but allow for YAML as well. Currently need to alter global in order to utilize YAML.

Describe the solution you'd like

https://github.com/awslabs/aws-lambda-powertools-python/blob/79414c8164e839cdfe1839c2c9f0d590df33f4b2/aws_lambda_powertools/utilities/feature_flags/appconfig.py#L15 needs to be DEFAULT_TRANSFORM_TYPE and transform arguments needs added to AppConfigStore.__init__

Describe alternatives you've considered

Would like to standardize to YAML for appconfig all around and this is a blocker.

Additional context

Just a nit.

@michaelbrewer
Copy link
Contributor

This would have to include an optional dependency like PyYaml

@heitorlessa heitorlessa transferred this issue from aws-powertools/powertools-lambda-python Nov 13, 2021
@heitorlessa heitorlessa transferred this issue from aws-powertools/powertools-lambda Apr 28, 2022
@heitorlessa
Copy link
Contributor

Closing as dup: #1170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants