-
Notifications
You must be signed in to change notification settings - Fork 428
feat: Only install typing-extensions dependency when necessary missing in some files #3091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for opening your first issue here! We'll come back to you as soon as we can. |
hey @HarbingersRequiem, thank you for reporting it -- did it cause you a runtime error in Lambda? if so, we'll switch it to Apologies for letting this slip during PRs, we'll think of a linter or a shared types to make this sustainable. |
Hey @heitorlessa, it did, yeah. Got this out of it "[ERROR] Runtime.ImportModuleError: Unable to import module 'lambda_function': No module named 'typing_extensions' Traceback (most recent call last):" Thanks for the quick response on it! |
okay, working on that now. Switching to bug. |
One quick note only... powertools-lambda-python/pyproject.toml Line 36 in 86619e5
That shouldn't cause the |
PR in, classified as |
All good and tested. Because we can't reproduce at runtime when installing the latest powertools for AWS version, we'll make a release tomorrow instead of now. Still, we care about it :) |
|
This is now released under 2.25.0 version! |
Use case
This is the same issue as noted in #280. Looks like the following files are missing the conditionals put in which is causing issues, for me at least, with some Lambda scripts:
Solution/User Experience
Same as previous feat. Add the conditionals around the import for typing_extensions
Alternative solutions
No response
Acknowledgment
The text was updated successfully, but these errors were encountered: