From 3e84be4554b6d51b3ab0607cf53ae146ae5f78e9 Mon Sep 17 00:00:00 2001 From: "Shane R. Spencer" <305301+whardier@users.noreply.github.com> Date: Thu, 2 Dec 2021 10:16:39 -0900 Subject: [PATCH 1/2] Update metric.py --- aws_lambda_powertools/metrics/metric.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/aws_lambda_powertools/metrics/metric.py b/aws_lambda_powertools/metrics/metric.py index a30f428e38e..af987bb6a45 100644 --- a/aws_lambda_powertools/metrics/metric.py +++ b/aws_lambda_powertools/metrics/metric.py @@ -1,7 +1,7 @@ import json import logging from contextlib import contextmanager -from typing import Dict, Optional, Union +from typing import Dict, Iterator, Optional, Union from .base import MetricManager, MetricUnit @@ -61,7 +61,7 @@ def add_metric(self, name: str, unit: Union[MetricUnit, str], value: float) -> N @contextmanager -def single_metric(name: str, unit: MetricUnit, value: float, namespace: Optional[str] = None): +def single_metric(name: str, unit: MetricUnit, value: float, namespace: Optional[str] = None) -> Iterator[SingleMetric]: """Context manager to simplify creation of a single metric Example From de51add8a3a810730c145b3f50ec2d6399b4c366 Mon Sep 17 00:00:00 2001 From: Heitor Lessa Date: Wed, 8 Dec 2021 09:50:30 +0100 Subject: [PATCH 2/2] fix(type): use Generator over Iterator --- aws_lambda_powertools/metrics/metric.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/aws_lambda_powertools/metrics/metric.py b/aws_lambda_powertools/metrics/metric.py index af987bb6a45..76ff4339dea 100644 --- a/aws_lambda_powertools/metrics/metric.py +++ b/aws_lambda_powertools/metrics/metric.py @@ -1,7 +1,7 @@ import json import logging from contextlib import contextmanager -from typing import Dict, Iterator, Optional, Union +from typing import Dict, Optional, Union, Generator from .base import MetricManager, MetricUnit @@ -61,7 +61,7 @@ def add_metric(self, name: str, unit: Union[MetricUnit, str], value: float) -> N @contextmanager -def single_metric(name: str, unit: MetricUnit, value: float, namespace: Optional[str] = None) -> Iterator[SingleMetric]: +def single_metric(name: str, unit: MetricUnit, value: float, namespace: Optional[str] = None) -> Generator[SingleMetric, None, None]: """Context manager to simplify creation of a single metric Example