Skip to content

Maintenance: extract docs/snippets linting in its own CI step #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
dreamorosi opened this issue Feb 7, 2023 · 1 comment · Fixed by #1274
Closed
1 of 2 tasks

Maintenance: extract docs/snippets linting in its own CI step #1275

dreamorosi opened this issue Feb 7, 2023 · 1 comment · Fixed by #1274
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@dreamorosi
Copy link
Contributor

Summary

#1259 introduced changes that allow us to automatically lint the contents of the code snippets present in the docs. When redacting the PR, these checks were conflated as part of the unit tests/linting for the core utilities. This is fine, however if the linting of these code snippets fails, the failure would be opaque for the reviewers as it would appear as part of the main checks (see img below):
image

Why is this needed?

For a better and more granular at-a-glance view for both maintainers and PR authors, it would be great to have these checks in a separate item/steps so that it's immediately clear where the failure happened.

Which area does this relate to?

Automation

Solution

Update the workflow that runs the tests & linting so that the check is extracted and shows up as a separate item in the PR view:
image

Acknowledgment

@dreamorosi dreamorosi added automation This item relates to automation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) confirmed The scope is clear, ready for implementation labels Feb 7, 2023
@dreamorosi dreamorosi self-assigned this Feb 7, 2023
@dreamorosi dreamorosi linked a pull request Feb 7, 2023 that will close this issue
13 tasks
@github-project-automation github-project-automation bot moved this from Shipped to Coming soon in AWS Lambda Powertools for TypeScript Feb 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release This item has been merged and will be released soon label Feb 7, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in AWS Lambda Powertools for TypeScript Feb 27, 2023
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon confirmed The scope is clear, ready for implementation labels Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant