Skip to content

Bug: Support for middy 6 #3401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
having-fun-serverless opened this issue Dec 4, 2024 · 3 comments
Closed

Bug: Support for middy 6 #3401

having-fun-serverless opened this issue Dec 4, 2024 · 3 comments
Labels
duplicate This issue is a duplicate of an existing one rejected This is something we will not be working on. At least, not in the measurable future

Comments

@having-fun-serverless
Copy link
Contributor

Expected Behavior

Ability to work with the power tool's logger and middy 6 successfully in the same project.

Current Behavior

I'm starting a new project with middy 6, when trying to install the latest @aws-lambda-powertools/logger package, I'm getting the following error:

npm error While resolving: @aws-lambda-powertools/[email protected]
npm error Found: @middy/[email protected]
npm error node_modules/@middy/core
npm error   @middy/core@"^6.0.0" from the root project
npm error
npm error Could not resolve dependency:
npm error peerOptional @middy/core@"4.x || 5.x" from @aws-lambda-powertools/[email protected]
npm error node_modules/@aws-lambda-powertools/logger
npm error   @aws-lambda-powertools/logger@"*" from the root project
npm error
npm error Conflicting peer dependency: @middy/[email protected]
npm error node_modules/@middy/core
npm error   peerOptional @middy/core@"4.x || 5.x" from @aws-lambda-powertools/[email protected]
npm error   node_modules/@aws-lambda-powertools/logger
npm error     @aws-lambda-powertools/logger@"*" from the root project

Code snippet

My current dependencies list:

"devDependencies": {
    "@aws-sdk/client-sts": "^3.699.0",
    "@eslint/js": "^9.15.0",
    "@jest/globals": "^29.2.0",
    "@types/aws-lambda": "^8.10.146",
    "@types/http-errors": "^2.0.4",
    "@types/jest": "^29.2.0",
    "@types/node": "^22.9.4",
    "@types/validator": "^13.12.2",
    "@types/xml2js": "^0.4.14",
    "aws-sdk-client-mock": "^4.1.0",
    "aws-sdk-client-mock-jest": "^4.1.0",
    "eslint": "^9.15.0",
    "globals": "^15.12.0",
    "jest": "^29.2.1",
    "npm-run-all": "^4.1.5",
    "prettier": "^3.3.3",
    "ts-jest": "^29.0.5",
    "ts-node": "^10.9.1",
    "typescript": "^5.7.2",
    "esbuild": "^0.24.0"
  },
  "dependencies": {
    "@aws-sdk/client-dynamodb": "^3.699.0",
    "@aws-sdk/client-s3": "^3.701.0",
    "@middy/core": "^6.0.0",
    "@middy/http-json-body-parser": "^6.0.0",
    "@middy/validator": "^6.0.0",
    "axios": "^1.7.8",
    "http-errors": "^2.0.0",
    "validator": "^13.12.0",
    "xml2js": "^0.6.2"
  },
  "engines": {
    "node": ">22.0.0"
  }

Steps to Reproduce

  1. npm install --save @middy/core
  2. npm install @aws-lambda-powertools/logger

Possible Solution

No response

Powertools for AWS Lambda (TypeScript) version

latest

AWS Lambda function runtime

22.x

Packaging format used

npm

Execution logs

@having-fun-serverless having-fun-serverless added bug Something isn't working triage This item has not been triaged by a maintainer, please wait labels Dec 4, 2024
Copy link

boring-cyborg bot commented Dec 4, 2024

Thanks for opening your first issue here! We'll come back to you as soon as we can.
In the meantime, check out the #typescript channel on our Powertools for AWS Lambda Discord: Invite link

@dreamorosi
Copy link
Contributor

Thank you for opening this issue.

We already had a request for this in #3367 and merged the change in #3368.

The change will be included in the next version.

@dreamorosi dreamorosi closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi added duplicate This issue is a duplicate of an existing one rejected This is something we will not be working on. At least, not in the measurable future and removed bug Something isn't working triage This item has not been triaged by a maintainer, please wait labels Dec 6, 2024
@dreamorosi dreamorosi moved this from Coming soon to Closed in Powertools for AWS Lambda (TypeScript) Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue is a duplicate of an existing one rejected This is something we will not be working on. At least, not in the measurable future
Projects
Development

No branches or pull requests

2 participants