Skip to content

Docs: Improve contrast in source code expressions for low-eyesight #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
heitorlessa opened this issue Dec 28, 2021 · 2 comments · Fixed by #370
Closed

Docs: Improve contrast in source code expressions for low-eyesight #360

heitorlessa opened this issue Dec 28, 2021 · 2 comments · Fixed by #370
Assignees
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation
Milestone

Comments

@heitorlessa
Copy link
Contributor

Description of the improvement

Summary of the proposal

BEFORE

image

AFTER

image

How, where did you look for information

Missing or unclear documentation

Improvement

Ideally this should be handled in CSS Selectors, though I haven't taken the time to ensure it differentiates between full snippets and short code expression as both use <code> tag.

Related existing documentation

Related issues, RFCs

@heitorlessa heitorlessa added the documentation Improvements or additions to documentation label Dec 28, 2021
@saragerion saragerion added the all label Dec 28, 2021
@dreamorosi dreamorosi self-assigned this Dec 29, 2021
@dreamorosi dreamorosi added this to the beta-release milestone Dec 29, 2021
@heitorlessa
Copy link
Contributor Author

heitorlessa commented Dec 30, 2021

UPDATE: Factor code expressions in lists too.

Add this to extra.css to fix it consistently - I'm gonna do this on Python one.. cc @pankajagrawal16. This will only make those small code expressions not the code blocks.

docs/stylesheets/extra.css*

p > code,
li > code {
	font-weight: bold
}

image

@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi changed the title All: Improve contrast in source code expressions for low-eyesight Docs: Improve contrast in source code expressions for low-eyesight Nov 14, 2022
@dreamorosi dreamorosi added the completed This item is complete and has been merged/shipped label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants