fix(logger): handle illegal null
/undefined
as extra args
#3614
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR adds an extra runtime check to values passed as
extra
arguments to a Logger logging method (i.e.logger.info('message', extra);
). With the fix added to this PR we are now skipping these values when they arenull
orundefined
rather than trying to process them, which addresses the bug described in the linked issue.For the sake of completeness, TypeScript already forbids passing these types to the logger methods, so this case could happen only if:
any
// @ts-expect-error
or// @ts-ignore
)Nevertheless, given the above it's still worth adding a runtime check in this case - especially because this case was handled gracefully in previous versions of Logger.
Issue number: fixes #3613
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.