You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/ISSUE_TEMPLATE/bug_report.md
+1-1
Original file line number
Diff line number
Diff line change
@@ -17,7 +17,7 @@ Steps to reproduce the behavior.
17
17
A clear and concise description of what you expected to happen.
18
18
19
19
**Please complete the following information about the solution:**
20
-
-[ ] Version: [e.g. v1.0.4]
20
+
-[ ] Version: [e.g. v1.0.5]
21
21
22
22
To get the version of the solution, you can look at the description of the created CloudFormation stack. For example, "_(SO0021) - Video On Demand workflow with AWS Step Functions, MediaConvert, MediaPackage, S3, CloudFront and DynamoDB. Version **v5.0.0**_". If the description does not contain the version information, you can look at the mappings section of the template:
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+11-13
Original file line number
Diff line number
Diff line change
@@ -6,24 +6,23 @@ documentation, we greatly value feedback and contributions from our community.
6
6
Please read through this document before submitting any issues or pull requests to ensure we have all the necessary
7
7
information to effectively respond to your bug report or contribution.
8
8
9
-
10
9
## Reporting Bugs/Feature Requests
11
10
12
11
We welcome you to use the GitHub issue tracker to report bugs or suggest features.
13
12
14
13
When filing an issue, please check [existing open](https://github.com/aws-solutions/scalable-analytics-using-apache-druid-on-aws/issues), or [recently closed](https://github.com/aws-solutions/scalable-analytics-using-apache-druid-on-aws/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aclosed%20), issues to make sure somebody else hasn't already
15
14
reported the issue. Please try to include as much information as you can. Details like these are incredibly useful:
16
15
17
-
* A reproducible test case or series of steps
18
-
* The version of our code being used
19
-
* Any modifications you've made relevant to the bug
20
-
* Anything unusual about your environment or deployment
21
-
16
+
- A reproducible test case or series of steps
17
+
- The version of our code being used
18
+
- Any modifications you've made relevant to the bug
19
+
- Anything unusual about your environment or deployment
22
20
23
21
## Contributing via Pull Requests
22
+
24
23
Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:
25
24
26
-
1. You are working against the latest source on the *main* branch.
25
+
1. You are working against the latest source on the _master_ branch.
27
26
2. You check existing open, and recently merged, pull requests to make sure someone else hasn't addressed the problem already.
28
27
3. You open an issue to discuss any significant work - we would hate for your time to be wasted.
29
28
@@ -39,23 +38,22 @@ To send us a pull request, please:
39
38
GitHub provides additional document on [forking a repository](https://help.github.com/articles/fork-a-repo/) and
40
39
[creating a pull request](https://help.github.com/articles/creating-a-pull-request/).
41
40
42
-
43
41
## Finding contributions to work on
44
-
Looking at the existing issues is a great way to find something to contribute on. As our projects, by default, use the default GitHub issue labels ((enhancement/bug/duplicate/help wanted/invalid/question/wontfix), looking at any ['help wanted'](https://github.com/aws-solutions/scalable-analytics-using-apache-druid-on-aws/labels/help%20wanted) issues is a great place to start.
45
42
43
+
Looking at the existing issues is a great way to find something to contribute on. As our projects, by default, use the default GitHub issue labels ((enhancement/bug/duplicate/help wanted/invalid/question/wontfix), looking at any ['help wanted'](https://github.com/aws-solutions/scalable-analytics-using-apache-druid-on-aws/labels/help%20wanted) issues is a great place to start.
46
44
47
45
## Code of Conduct
46
+
48
47
This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
49
48
For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
If you discover a potential security issue in this project we ask that you notify AWS/Amazon Security via our [vulnerability reporting page](http://aws.amazon.com/security/vulnerability-reporting/). Please do **not** create a public github issue.
55
52
53
+
If you discover a potential security issue in this project we ask that you notify AWS/Amazon Security via our [vulnerability reporting page](http://aws.amazon.com/security/vulnerability-reporting/). Please do **not** create a public github issue.
56
54
57
55
## Licensing
58
56
59
-
See the [LICENSE](https://github.com/aws-solutions/scalable-analytics-using-apache-druid-on-aws/blob/main/LICENSE.txt) file for our project's licensing. We will ask you to confirm the licensing of your contribution.
57
+
See the [LICENSE](https://github.com/aws-solutions/scalable-analytics-using-apache-druid-on-aws/blob/master/LICENSE) file for our project's licensing. We will ask you to confirm the licensing of your contribution.
60
58
61
-
We may ask you to sign a [Contributor License Agreement (CLA)](http://en.wikipedia.org/wiki/Contributor_License_Agreement) for larger changes.
59
+
We may ask you to sign a [Contributor License Agreement (CLA)](https://en.wikipedia.org/wiki/Contributor_License_Agreement) for larger changes.
Copy file name to clipboardExpand all lines: README.md
+6-6
Original file line number
Diff line number
Diff line change
@@ -125,13 +125,13 @@ The solution deploys the following components that work together to provide a pr
125
125
126
126
- The latest version of the [AWS CLI](https://aws.amazon.com/cli/), installed and configured.
127
127
- The latest version of the [AWS CDK](https://docs.aws.amazon.com/cdk/latest/guide/home.html).
128
-
-[Nodejs](https://docs.npmjs.com/getting-started) version 18 or newer.
128
+
-[Nodejs](https://docs.npmjs.com/getting-started) version 20 or newer.
129
129
-[Python](https://www.python.org/) version 3.12 or newer.
130
130
-[Git](https://git-scm.com/) command line
131
131
- Java Runtime
132
-
- The solution requires a Java 8 Runtime. We strongly recommend using [Amazon Corretto 8](https://docs.aws.amazon.com/corretto/latest/corretto-8-ug/downloads-list.html). Alternatively, you can also use other OpenJDKs such as [Eclipse Temurin](https://adoptium.net/en-GB/temurin/releases/?version=8).
132
+
- The solution requires a Java 17 Runtime. We strongly recommend using [Amazon Corretto 17](https://docs.aws.amazon.com/corretto/latest/corretto-17-ug/downloads-list.html). Alternatively, you can also use other OpenJDKs such as [Eclipse Temurin](https://adoptium.net/en-GB/temurin/releases/?version=17).
- We recommend configuring Maven to use an OpenJDK8 compatible JAVA version, such as Amazon Corretto 8.
134
+
- We recommend configuring Maven to use an OpenJDK17 compatible JAVA version, such as Amazon Corretto 17.
135
135
-[Docker](https://docs.docker.com/get-docker/)
136
136
-[Curl](https://curl.se/download.html)
137
137
@@ -149,16 +149,16 @@ Use the `source/cdk.json` file to configure the solution. It is recommended to c
149
149
150
150
**AMI configuration (optional)**
151
151
152
-
The `EC2` hosting option by default provisions EC2 instances with Amazon Linux 2. This can be overriden by specifying the `customAmi` object in the `cdk.json` file. This object should provide the AMI name and owners' account IDs or alias that `cdk` would use to perform an AMI lookup. Depending on the instance types utilized in the cluster, please supply the corresponding AMI for "arm64" (Graviton instances) or "amd64" (x86-based instance types). The solution has been tested with Amazon Linux, Ubuntu 20.04 LTS and Ubuntu 22.04 LTS.
152
+
The `EC2` hosting option by default provisions EC2 instances with Amazon Linux 2. This can be overriden by specifying the `customAmi` object in the `cdk.json` file. This object should provide the AMI name and owners' account IDs or alias that `cdk` would use to perform an AMI lookup. Depending on the instance types utilized in the cluster, please supply the corresponding AMI for "arm64" (Graviton instances) or "amd64" (x86-based instance types). The solution has been tested with Amazon Linux 2 and Ubuntu 22.04 LTS.
0 commit comments