Skip to content

Commit 719cda7

Browse files
authored
fix(toolkit-lib): remove deprecated options (#307)
Remove deprecated options that have been replaced by IoHost functionality: - Remove `requireApproval` from DeployOptions (deprecated) - Remove `ci` and `progress` from DeployOptions (deprecated) - Remove `ci` from DestroyOptions (deprecated) - Remove related usage in toolkit.ts implementation BREAKING CHANGE: Removes previously deprecated options from toolkit actions. From `DeployOptions`, removed the options `requireApproval`, `ci` and `progress`. From `DestroyOptions`, removed the option `ci`. All removed options were previously deprecated and had no functional effect. Instead you should implement desired functionality in your `IIoHost` implementation. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
1 parent 3e8359c commit 719cda7

File tree

3 files changed

+0
-32
lines changed

3 files changed

+0
-32
lines changed

packages/@aws-cdk/toolkit-lib/lib/actions/deploy/index.ts

-23
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import type { BaseDeployOptions } from './private/deploy-options';
22
import type { Tag } from '../../api/aws-cdk';
3-
import type { RequireApproval } from '../../api/shared-public';
43

54
export type DeploymentMethod = DirectDeploymentMethod | ChangeSetDeploymentMethod;
65

@@ -103,14 +102,6 @@ export interface DeployOptions extends BaseDeployOptions {
103102
*/
104103
readonly notificationArns?: string[];
105104

106-
/**
107-
* Require a confirmation for security relevant changes before continuing with the deployment
108-
*
109-
* @default RequireApproval.NEVER
110-
* @deprecated requireApproval is governed by the `IIoHost`. This property is no longer used.
111-
*/
112-
readonly requireApproval?: RequireApproval;
113-
114105
/**
115106
* Tags to pass to CloudFormation for deployment
116107
*/
@@ -146,20 +137,6 @@ export interface DeployOptions extends BaseDeployOptions {
146137
*/
147138
readonly assetBuildTime?: AssetBuildTime;
148139

149-
/**
150-
* Change stack watcher output to CI mode.
151-
*
152-
* @deprecated has no functionality, please implement in your IoHost
153-
*/
154-
readonly ci?: boolean;
155-
156-
/**
157-
* Display mode for stack deployment progress.
158-
*
159-
* @deprecated has no functionality, please implement in your IoHost
160-
*/
161-
readonly progress?: any;
162-
163140
/**
164141
* Represents configuration property overrides for hotswap deployments.
165142
* Currently only supported by ECS.

packages/@aws-cdk/toolkit-lib/lib/actions/destroy/index.ts

-7
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,4 @@ export interface DestroyOptions {
1010
* The arn of the IAM role to use
1111
*/
1212
readonly roleArn?: string;
13-
14-
/**
15-
* Change stack watcher output to CI mode.
16-
*
17-
* @deprecated has no effect, please implement in IoHost instead
18-
*/
19-
readonly ci?: boolean;
2013
}

packages/@aws-cdk/toolkit-lib/lib/toolkit/toolkit.ts

-2
Original file line numberDiff line numberDiff line change
@@ -517,7 +517,6 @@ export class Toolkit extends CloudAssemblySourceBuilder implements AsyncDisposab
517517
await this._destroy(assembly, 'deploy', {
518518
stacks: { patterns: [stack.hierarchicalId], strategy: StackSelectionStrategy.PATTERN_MUST_MATCH_SINGLE },
519519
roleArn: options.roleArn,
520-
ci: options.ci,
521520
});
522521

523522
return;
@@ -1005,7 +1004,6 @@ export class Toolkit extends CloudAssemblySourceBuilder implements AsyncDisposab
10051004
const hotswap = options.hotswap ?? HotswapMode.HOTSWAP_ONLY;
10061005
const deployOptions: ExtendedDeployOptions = {
10071006
...options,
1008-
requireApproval: RequireApproval.NEVER,
10091007
cloudWatchLogMonitor,
10101008
hotswap,
10111009
extraUserAgent: `cdk-watch/hotswap-${hotswap === HotswapMode.FULL_DEPLOYMENT ? 'off' : 'on'}`,

0 commit comments

Comments
 (0)