Skip to content

Commit 1df1a78

Browse files
authored
fix(scheduler-targets): update kinesis firehose imports (#33615)
### Issue # (if applicable) Closes #<issue number here>. ### Reason for this change The Kinesis Firehose module is now stabilized, need to update package imports accordingly. ### Description of changes Fix import paths for Kinesis Firehose target ### Describe any new or updated permissions being added n/a ### Description of how you validated changes Updated integration test ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 183556d commit 1df1a78

12 files changed

+7982
-3809
lines changed

packages/@aws-cdk/aws-scheduler-targets-alpha/lib/kinesis-data-firehose-put-record.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import { IDeliveryStream } from '@aws-cdk/aws-kinesisfirehose-alpha';
21
import { IScheduleTarget } from '@aws-cdk/aws-scheduler-alpha';
32
import { IRole, PolicyStatement } from 'aws-cdk-lib/aws-iam';
3+
import { IDeliveryStream } from 'aws-cdk-lib/aws-kinesisfirehose';
44
import { ScheduleTargetBase, ScheduleTargetBaseProps } from './target';
55

66
/**

packages/@aws-cdk/aws-scheduler-targets-alpha/package.json

-5
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,6 @@
8282
},
8383
"license": "Apache-2.0",
8484
"devDependencies": {
85-
"@aws-cdk/aws-kinesisfirehose-destinations-alpha": "0.0.0",
86-
"@aws-cdk/aws-kinesisfirehose-alpha": "0.0.0",
8785
"@aws-cdk/aws-scheduler-alpha": "0.0.0",
8886
"@aws-cdk/cdk-build-tools": "0.0.0",
8987
"@aws-cdk/integ-runner": "0.0.0",
@@ -93,10 +91,7 @@
9391
"aws-cdk-lib": "0.0.0",
9492
"constructs": "^10.0.0"
9593
},
96-
"dependencies": {},
9794
"peerDependencies": {
98-
"@aws-cdk/aws-kinesisfirehose-destinations-alpha": "0.0.0",
99-
"@aws-cdk/aws-kinesisfirehose-alpha": "0.0.0",
10095
"@aws-cdk/aws-scheduler-alpha": "0.0.0",
10196
"aws-cdk-lib": "^0.0.0",
10297
"constructs": "^10.0.0"
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk/aws-scheduler-targets-alpha/test/integ.kinesis-data-firehose-put-record.js.snapshot/aws-cdk-scheduler-targets-firehose-put-record.assets.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk/aws-scheduler-targets-alpha/test/integ.kinesis-data-firehose-put-record.js.snapshot/cdk.out

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk/aws-scheduler-targets-alpha/test/integ.kinesis-data-firehose-put-record.js.snapshot/integ.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk/aws-scheduler-targets-alpha/test/integ.kinesis-data-firehose-put-record.js.snapshot/integrationtestfirehoseputrecordDefaultTestDeployAssert781A189E.assets.json

+6-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk/aws-scheduler-targets-alpha/test/integ.kinesis-data-firehose-put-record.js.snapshot/integrationtestfirehoseputrecordDefaultTestDeployAssert781A189E.template.json

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk/aws-scheduler-targets-alpha/test/integ.kinesis-data-firehose-put-record.js.snapshot/manifest.json

+5-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk/aws-scheduler-targets-alpha/test/integ.kinesis-data-firehose-put-record.js.snapshot/tree.json

+4-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk/aws-scheduler-targets-alpha/test/integ.kinesis-data-firehose-put-record.ts

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
1-
import * as firehose from '@aws-cdk/aws-kinesisfirehose-alpha';
2-
import * as destinations from '@aws-cdk/aws-kinesisfirehose-destinations-alpha';
31
import * as scheduler from '@aws-cdk/aws-scheduler-alpha';
42
import { AwsApiCall, ExpectedResult, IntegTest } from '@aws-cdk/integ-tests-alpha';
53
import * as cdk from 'aws-cdk-lib';
4+
import * as firehose from 'aws-cdk-lib/aws-kinesisfirehose';
65
import { Bucket } from 'aws-cdk-lib/aws-s3';
76
import { KinesisDataFirehosePutRecord } from '../lib';
87

@@ -31,7 +30,7 @@ const deliveryStreamRole = new cdk.aws_iam.Role(stack, 'deliveryStreamRole', {
3130
destinationBucket.grantReadWrite(deliveryStreamRole);
3231

3332
const firehoseStream = new firehose.DeliveryStream(stack, 'MyFirehoseStream', {
34-
destination: new destinations.S3Bucket(destinationBucket, {
33+
destination: new firehose.S3Bucket(destinationBucket, {
3534
role: deliveryStreamRole,
3635
bufferingInterval: cdk.Duration.minutes(1),
3736
}),

packages/@aws-cdk/aws-scheduler-targets-alpha/test/kinesis-data-firehose-put-record.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import * as firehose from '@aws-cdk/aws-kinesisfirehose-alpha';
21
import { ScheduleExpression, Schedule, Group } from '@aws-cdk/aws-scheduler-alpha';
32
import { App, CfnResource, Duration, Stack } from 'aws-cdk-lib';
43
import { Template } from 'aws-cdk-lib/assertions';
54
import { AccountRootPrincipal, Role } from 'aws-cdk-lib/aws-iam';
5+
import * as firehose from 'aws-cdk-lib/aws-kinesisfirehose';
66
import * as sqs from 'aws-cdk-lib/aws-sqs';
77
import { Construct } from 'constructs';
88
import { KinesisDataFirehosePutRecord } from '../lib';

0 commit comments

Comments
 (0)