Skip to content

Commit 3656a4c

Browse files
chore(pkglint): uncomment pkglint functionality (#28622)
This was unintentionally commented out in a previous PR. Adding it back in. This also includes the changes that pkglint would have picked up, if not commented out. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 65505f0 commit 3656a4c

File tree

4 files changed

+4
-6
lines changed

4 files changed

+4
-6
lines changed

packages/aws-cdk/THIRD_PARTY_LICENSES

+1-1
Original file line numberDiff line numberDiff line change
@@ -461,7 +461,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
461461

462462
----------------
463463

464-
** cdk-from-cfn@0.91.0 - https://www.npmjs.com/package/cdk-from-cfn/v/0.91.0 | MIT OR Apache-2.0
464+
** cdk-from-cfn@0.113.0 - https://www.npmjs.com/package/cdk-from-cfn/v/0.113.0 | MIT OR Apache-2.0
465465

466466
----------------
467467

packages/aws-cdk/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -155,4 +155,4 @@
155155
"publishConfig": {
156156
"tag": "latest"
157157
}
158-
}
158+
}

tools/@aws-cdk/cdk-build-tools/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,4 +86,4 @@
8686
"ubergen": {
8787
"exclude": true
8888
}
89-
}
89+
}

tools/@aws-cdk/pkglint/bin/pkglint.ts

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#!/usr/bin/env node
22
import * as path from 'path';
33
import * as yargs from 'yargs';
4-
//import { findPackageJsons, ValidationRule } from '../lib';
4+
import { findPackageJsons, ValidationRule } from '../lib';
55

66
const argv = yargs
77
.env('PKGLINT_')
@@ -19,7 +19,6 @@ if (typeof(directory) !== 'string') {
1919
argv.directory = path.resolve(directory, process.cwd());
2020

2121
async function main(): Promise<void> {
22-
/*
2322
const ruleClasses = require('../lib/rules'); // eslint-disable-line @typescript-eslint/no-require-imports
2423
const rules: ValidationRule[] = Object.keys(ruleClasses).map(key => new ruleClasses[key]()).filter(obj => obj instanceof ValidationRule);
2524

@@ -37,7 +36,6 @@ async function main(): Promise<void> {
3736
if (pkgs.some(p => p.hasReports)) {
3837
throw new Error('Some package.json files had errors');
3938
}
40-
*/
4139
}
4240

4341
main().catch((e) => {

0 commit comments

Comments
 (0)