Skip to content

Commit 4ada3ea

Browse files
authored
fix(event-targets): ecsTask uses invalid task definition arn in policy (#31615)
### Issue # (if applicable) Closes #30390 . ### Reason for this change This is extending a closed PR #30484 by @jwoehrle . I couldn't update that PR so I am creating this new one. Reason for this change is due to a AWS ECS campaign where they are asking customers to add task definition revision number (or wildcard as the revision number) to IAM policies. ### Description of changes When adding permission to the Events Role to allow it to use the task definition, check if the task definition arn has a revision number, if yes, do nothing, if not, add the wildcard `*`. This is only done when the task definition arn is not using any token. ### Description of how you validated changes Unit tests and Integ tests are added. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 857bdc7 commit 4ada3ea

File tree

13 files changed

+2783
-1
lines changed

13 files changed

+2783
-1
lines changed

packages/@aws-cdk-testing/framework-integ/test/aws-events-targets/test/ecs/integ.ecs-imported-task-def.js.snapshot/IntegEcsImportedTaskDefStack.assets.json

+32
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)