Skip to content

Commit 4e7f5c4

Browse files
fix(appsync): appsync.HttpDataSourceProps erroneously extends BaseDataSourceProps (#32065)
### Reason for this change Closes #31979. Replaces #29689. In #11185, the `HttpDataSource` class was updated to extend `BackedDataSource` instead of `BaseDataSource`, however the `HttpDataSourceProps` type wasn't updated to reflect this change. This PR makes the `HttpDataSourceProps` type reflect the change. ### Description of changes Makes the `HttpDataSourceProps` type extend `BackedDataSourceProps`, instead of `BaseDataSourceProps`. This means users are able to provide the `serviceRole` prop without getting a type error. ### Description of how you validated changes The below code snippet no longer gives an incorrect type error when providing the serviceRole, as it did before: ```ts import * as appsync from "aws-cdk-lib/aws-appsync"; import type { IRole } from "aws-cdk-lib/aws-iam"; declare const myApi: appsync.GraphqlApi; declare const serviceRole: IRole; const stepFunctionHttpDataSource = new appsync.HttpDataSource( myApi, "MyStepFunctionHTTPDataSource", { api: myApi, authorizationConfig: { signingRegion: "eu-west-1", signingServiceName: "states", }, endpoint: `https://states.eu-west-1.amazonaws.com`, name: "StepFunctionHTTPDataSource", // Providing the `serviceRole` now correctly DOESN'T throw a type error serviceRole, } ); ```
1 parent aed8ad1 commit 4e7f5c4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/aws-cdk-lib/aws-appsync/lib/data-source.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ export interface AwsIamConfig {
255255
/**
256256
* Properties for an AppSync http datasource
257257
*/
258-
export interface HttpDataSourceProps extends BaseDataSourceProps {
258+
export interface HttpDataSourceProps extends BackedDataSourceProps {
259259
/**
260260
* The http endpoint
261261
*/

0 commit comments

Comments
 (0)