Skip to content

Commit 4f735d2

Browse files
authored
Merge branch 'main' into fix-https-alb-listener
2 parents 9791e14 + 3fe8ab4 commit 4f735d2

File tree

8 files changed

+55
-12
lines changed

8 files changed

+55
-12
lines changed

packages/@aws-cdk-testing/framework-integ/test/aws-ses-actions/test/integ.actions.js.snapshot/aws-cdk-ses-receipt.template.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@
8686
"Action": "s3:PutObject",
8787
"Condition": {
8888
"StringEquals": {
89-
"aws:Referer": {
89+
"aws:SourceAccount": {
9090
"Ref": "AWS::AccountId"
9191
}
9292
}

packages/aws-cdk-lib/aws-ec2/lib/instance-types.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -858,6 +858,16 @@ export enum InstanceClass {
858858
*/
859859
I7IE = 'i7ie',
860860

861+
/**
862+
* I/O-optimized instances with local NVME drive powered by 5th generation Intel Xeon Scalable processors, 7th generation
863+
*/
864+
IO7_INTEL = 'io7_intel',
865+
866+
/**
867+
* I/O-optimized instances with local NVME drive powered by 5th generation Intel Xeon Scalable processors, 7th generation
868+
*/
869+
I7I = 'i7i',
870+
861871
/**
862872
* Storage optimized instances powered by Graviton4 processor, 8th generation
863873
*/
@@ -1845,6 +1855,8 @@ export class InstanceType {
18451855
[InstanceClass.IS4GEN]: 'is4gen',
18461856
[InstanceClass.STORAGE7_INTEL_STORAGE_OPTIMIZED]: 'i7ie',
18471857
[InstanceClass.I7IE]: 'i7ie',
1858+
[InstanceClass.IO7_INTEL]: 'i7i',
1859+
[InstanceClass.I7I]: 'i7i',
18481860
[InstanceClass.STORAGE8_GRAVITON]: 'i8g',
18491861
[InstanceClass.I8G]: 'i8g',
18501862
[InstanceClass.BURSTABLE2]: 't2',

packages/aws-cdk-lib/aws-ecs-patterns/lib/base/application-load-balanced-service-base.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,8 +219,8 @@ export interface ApplicationLoadBalancedServiceBaseProps {
219219
readonly cloudMapOptions?: CloudMapOptions;
220220

221221
/**
222-
* Specifies whether the load balancer should redirect traffic on port 80 to port 443 to support HTTP->HTTPS redirects
223-
* This is only valid if the protocol of the ALB is HTTPS
222+
* Specifies whether the load balancer should redirect traffic on port 80 to the {@link listenerPort} to support HTTP->HTTPS redirects.
223+
* This is only valid if the protocol of the ALB is HTTPS.
224224
*
225225
* @default false
226226
*/

packages/aws-cdk-lib/aws-rds/lib/instance-engine.ts

Lines changed: 28 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,10 @@ export class MariaDbEngineVersion {
371371
*/
372372
public static readonly VER_10_3_39 = MariaDbEngineVersion.of('10.3.39', '10.3');
373373

374-
/** Version "10.4" (only a major version, without a specific minor version). */
374+
/**
375+
* Version "10.4" (only a major version, without a specific minor version)
376+
* @deprecated MariaDB 10.4 is no longer supported by Amazon RDS.
377+
*/
375378
public static readonly VER_10_4 = MariaDbEngineVersion.of('10.4', '10.4');
376379
/**
377380
* Version "10.4.8"
@@ -423,17 +426,35 @@ export class MariaDbEngineVersion {
423426
* @deprecated MariaDB 10.4.28 is no longer supported by Amazon RDS.
424427
*/
425428
public static readonly VER_10_4_28 = MariaDbEngineVersion.of('10.4.28', '10.4');
426-
/** Version "10.4.29". */
429+
/**
430+
* Version "10.4.29"
431+
* @deprecated MariaDB 10.4.29 is no longer supported by Amazon RDS.
432+
*/
427433
public static readonly VER_10_4_29 = MariaDbEngineVersion.of('10.4.29', '10.4');
428-
/** Version "10.4.30". */
434+
/**
435+
* Version "10.4.30"
436+
* @deprecated MariaDB 10.4.30 is no longer supported by Amazon RDS.
437+
*/
429438
public static readonly VER_10_4_30 = MariaDbEngineVersion.of('10.4.30', '10.4');
430-
/** Version "10.4.31". */
439+
/**
440+
* Version "10.4.31"
441+
* @deprecated MariaDB 10.4.31 is no longer supported by Amazon RDS.
442+
*/
431443
public static readonly VER_10_4_31 = MariaDbEngineVersion.of('10.4.31', '10.4');
432-
/** Version "10.4.32". */
444+
/**
445+
* Version "10.4.32"
446+
* @deprecated MariaDB 10.4.32 is no longer supported by Amazon RDS.
447+
*/
433448
public static readonly VER_10_4_32 = MariaDbEngineVersion.of('10.4.32', '10.4');
434-
/** Version "10.4.33". */
449+
/**
450+
* Version "10.4.33"
451+
* @deprecated MariaDB 10.4.33 is no longer supported by Amazon RDS.
452+
*/
435453
public static readonly VER_10_4_33 = MariaDbEngineVersion.of('10.4.33', '10.4');
436-
/** Version "10.4.34". */
454+
/**
455+
* Version "10.4.34"
456+
* @deprecated MariaDB 10.4.34 is no longer supported by Amazon RDS.
457+
*/
437458
public static readonly VER_10_4_34 = MariaDbEngineVersion.of('10.4.34', '10.4');
438459

439460
/** Version "10.5" (only a major version, without a specific minor version). */

packages/aws-cdk-lib/aws-ses-actions/lib/s3.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export class S3 implements ses.IReceiptRuleAction {
5555
resources: [this.props.bucket.arnForObjects(`${keyPattern}*`)],
5656
conditions: {
5757
StringEquals: {
58-
'aws:Referer': cdk.Aws.ACCOUNT_ID,
58+
'aws:SourceAccount': cdk.Aws.ACCOUNT_ID,
5959
},
6060
},
6161
});

packages/aws-cdk-lib/aws-ses-actions/test/actions.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ test('add s3 action', () => {
190190
Action: 's3:PutObject',
191191
Condition: {
192192
StringEquals: {
193-
'aws:Referer': {
193+
'aws:SourceAccount': {
194194
Ref: 'AWS::AccountId',
195195
},
196196
},

packages/aws-cdk-lib/aws-ses/README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,12 @@ new ses.AllowListReceiptFilter(this, 'AllowList', {
103103

104104
This will first create a block all filter and then create allow filters for the listed ip addresses.
105105

106+
### AWS Service Principal permissions
107+
108+
When adding an s3 action to a receipt rule, the CDK will automatically create a policy statement that allows the ses service principal to get write access to the bucket. This is done with the `SourceAccount` condition key, which is automatically added to the policy statement.
109+
Previously, the policy used the `Referer` condition key, which caused confused deputy problems when the bucket policy allowed access to the bucket for all principals.
110+
See more information in [this github issue](https://github.com/aws/aws-cdk/issues/29811)
111+
106112
## Email sending
107113

108114
### Dedicated IP pools

tools/@aws-cdk/enum-updater/lib/exclude-values.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,10 @@
6565
},
6666
"FunctionEventType": {
6767
"comment": "The origin-X events are only available to Lambda@Edge functions"
68+
},
69+
"PriceClass": {
70+
"values": ["None"],
71+
"comment": "NONE is not supported"
6872
}
6973
},
7074
"iot": {

0 commit comments

Comments
 (0)