Skip to content

Commit 51f0193

Browse files
authored
fix(eks): overly permissive trust policies (#25473)
The *CreationRole* and the *default MastersRole* use the account root principal in their trust policy, which is overly permissive. Instead, use the specific lambda handler roles that need it, and remove the default masters role. BREAKING CHANGE: A masters role is no longer provisioned by default. Use the `mastersRole` property to explicitly pass a role that needs cluster access. In addition, the creation role no longer allows any identity (with the appropriate `sts:AssumeRole` permissions) to assume it. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 16ae335 commit 51f0193

File tree

538 files changed

+17161
-18997
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

538 files changed

+17161
-18997
lines changed

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.alb-controller.js.snapshot/asset.68b8fc42fe6d1eb6e6c39212ce770fac02511440fecfc5b69a904fe8a19f6b8e/index.js

-59
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import { IsCompleteResponse, OnEventResponse } from '../../../custom-resources/lib/provider-framework/types';
21
import { EksClient, ResourceEvent, ResourceHandler } from './common';
2+
import { IsCompleteResponse, OnEventResponse } from '../../../custom-resources/lib/provider-framework/types';
33
export declare class ClusterResourceHandler extends ResourceHandler {
44
get clusterName(): string;
55
private readonly newProps;
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
/* eslint-disable no-console */
22

33
// eslint-disable-next-line import/no-extraneous-dependencies
4-
import { IsCompleteResponse, OnEventResponse } from '../../../custom-resources/lib/provider-framework/types';
54
// eslint-disable-next-line import/no-extraneous-dependencies
65
import * as aws from 'aws-sdk';
76
import { EksClient, ResourceEvent, ResourceHandler } from './common';
87
import { compareLoggingProps } from './compareLogging';
8+
import { IsCompleteResponse, OnEventResponse } from '../../../custom-resources/lib/provider-framework/types';
99

1010

1111
const MAX_CLUSTER_NAME_LEN = 100;
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import { IsCompleteResponse, OnEventResponse } from '../../../custom-resources/lib/provider-framework/types';
21
import * as aws from 'aws-sdk';
2+
import { IsCompleteResponse, OnEventResponse } from '../../../custom-resources/lib/provider-framework/types';
33
export interface EksUpdateId {
44
/**
55
* If this field is included in an event passed to "IsComplete", it means we

0 commit comments

Comments
 (0)