Skip to content

Commit 7901f07

Browse files
authored
feat(codepipeline-actions): support timeout for ManualApprovalAction (#33472)
### Issue # (if applicable) Closes #33473 ### Reason for this change The `TimeoutInMinutes` property, which is for the manual approval action, has been added to `ActionDeclaration` in CFn, but not yet added to `ManualApprovalAction` in CDK. > A timeout duration in minutes that can be applied against the ActionType’s default timeout value specified in [Quotas for AWS CodePipeline](https://docs.aws.amazon.com/codepipeline/latest/userguide/limits.html). This attribute is available only to the manual approval ActionType. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-actiondeclaration.html#cfn-codepipeline-pipeline-actiondeclaration-timeoutinminutes Other ref: https://docs.aws.amazon.com/codepipeline/latest/userguide/limits.html > Manual approval action account level default timeout: 7 days > > Note > The default timeout for the manual approval action can be overridden for a specific action in the pipeline, and it is configurable up to 86400 minutes (60 days) with a minimum value of 5 minutes. For more information, see [ActionDeclaration](https://docs.aws.amazon.com/codepipeline/latest/APIReference/API_ActionDeclaration.html) in the CodePipeline API Reference. > > When configured, this timeout is applied for the action. Otherwise, the account level default is used. ### Description of changes Added `timeout` to `ManualApprovalActionProps` and other related properties (such as Action, FullActionDescriptor and Stage). ### Describe any new or updated permissions being added ### Description of how you validated changes Both unit and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 3b7cf94 commit 7901f07

File tree

13 files changed

+500
-88
lines changed

13 files changed

+500
-88
lines changed

packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-manual-approval.js.snapshot/aws-cdk-codepipeline-manual-approval.assets.json

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-manual-approval.js.snapshot/aws-cdk-codepipeline-manual-approval.template.json

+11-10
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,12 @@
9696
"PipelineC660917D": {
9797
"Type": "AWS::CodePipeline::Pipeline",
9898
"Properties": {
99+
"ArtifactStore": {
100+
"Location": {
101+
"Ref": "Bucket83908E77"
102+
},
103+
"Type": "S3"
104+
},
99105
"RoleArn": {
100106
"Fn::GetAtt": [
101107
"PipelineRoleD68726F7",
@@ -156,18 +162,13 @@
156162
"Arn"
157163
]
158164
},
159-
"RunOrder": 1
165+
"RunOrder": 1,
166+
"TimeoutInMinutes": 10
160167
}
161168
],
162169
"Name": "Approve"
163170
}
164-
],
165-
"ArtifactStore": {
166-
"Location": {
167-
"Ref": "Bucket83908E77"
168-
},
169-
"Type": "S3"
170-
}
171+
]
171172
},
172173
"DependsOn": [
173174
"PipelineRoleDefaultPolicyC7A05455",
@@ -347,11 +348,11 @@
347348
"PipelineApproveManualApprovalTopicResourceadamruka85gmailcom202874CD": {
348349
"Type": "AWS::SNS::Subscription",
349350
"Properties": {
351+
"Endpoint": "[email protected]",
350352
"Protocol": "email",
351353
"TopicArn": {
352354
"Ref": "PipelineApproveManualApprovalTopicResourceF5A35B20"
353-
},
354-
"Endpoint": "[email protected]"
355+
}
355356
}
356357
}
357358
},

packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-manual-approval.js.snapshot/cdk.out

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-manual-approval.js.snapshot/integ.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-manual-approval.js.snapshot/manifest.json

+211-8
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)