Skip to content

Commit 8eeb8e4

Browse files
chore(s3): update annotation phrase of addReplicationPolicy() (#33459)
### Issue # (if applicable) None ### Reason for this change As mentioned in [this comment](#33360 (comment)), the annotation phrase is incorrect and may confuse users. The `addReplicationPolicy()` function works to add a resource policy for the destination bucket, but the annotation phrase says source bucket. ### Description of changes ```diff - For Cross-account S3 replication, ensure to set up permissions on source bucket using method addReplicationPolicy() + For Cross-account S3 replication, ensure to set up permissions on destination bucket using method addReplicationPolicy() ``` ### Describe any new or updated permissions being added None ### Description of how you validated changes None ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 8f3e793 commit 8eeb8e4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/aws-cdk-lib/aws-s3/lib/bucket.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2850,7 +2850,7 @@ export class Bucket extends BucketBase {
28502850
const isCrossAccount = sourceAccount !== destinationAccount;
28512851

28522852
if (isCrossAccount) {
2853-
Annotations.of(this).addInfo('For Cross-account S3 replication, ensure to set up permissions on source bucket using method addReplicationPolicy() ');
2853+
Annotations.of(this).addInfo('For Cross-account S3 replication, ensure to set up permissions on destination bucket using method addReplicationPolicy() ');
28542854
} else if (rule.accessControlTransition) {
28552855
throw new ValidationError('accessControlTranslation is only supported for cross-account replication', this);
28562856
}

0 commit comments

Comments
 (0)