Skip to content

Commit a21190e

Browse files
authored
fix(lambda-nodejs): do not require a frozen lockfile for bun (#32908)
### Issue #32906 Closes #32906. ### Reason for this change When I implemented `bun` support, I accidentally used `--frozen-lockfile`, which caused issues when the lockfile contained additional entries other than what's being bundled in the docker container. The issue has a small repro-case. ### Description of changes I removed the `--frozen-lockfile` flag, which resolved the problem. ### Describe any new or updated permissions being added N/A ### Description of how you validated changes I added an additional package to the `bun.lockb` file in the integration test. This caused the issue to occur in the test suite. Once I made the changes in this PR, the test started passing again. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 878ad54 commit a21190e

File tree

15 files changed

+355
-179
lines changed

15 files changed

+355
-179
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
{
2+
"/": "We call this _package.json so nx doesn't get confused. If you need to regenerate the lockfile, temporarily rename this file to package.json",
3+
"//": "It's important to have two dependencies here (one bundled, one not) to test that the lockfile can be updated in the docker container.",
4+
"dependencies": {
5+
"axios": "1.7.8",
6+
"express": "4.19.2"
7+
}
8+
}

Diff for: packages/@aws-cdk-testing/framework-integ/test/aws-lambda-nodejs/test/integ.dependencies-bun.js.snapshot/BunTestDefaultTestDeployAssert773BA602.assets.json

+6-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: packages/@aws-cdk-testing/framework-integ/test/aws-lambda-nodejs/test/integ.dependencies-bun.js.snapshot/BunTestDefaultTestDeployAssert773BA602.template.json

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: packages/@aws-cdk-testing/framework-integ/test/aws-lambda-nodejs/test/integ.dependencies-bun.js.snapshot/TestStack.assets.json

+6-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: packages/@aws-cdk-testing/framework-integ/test/aws-lambda-nodejs/test/integ.dependencies-bun.js.snapshot/TestStack.template.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"S3Bucket": {
3939
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
4040
},
41-
"S3Key": "06377804ec21f3cc33473a6b5853b2a873177c1ebe09b176c3ab1eef45287c97.zip"
41+
"S3Key": "34a0cfe827762d92939af809d39b2595744d7d29328d6ec419935ca5a9fe9116.zip"
4242
},
4343
"Handler": "index.handler",
4444
"Role": {
@@ -47,7 +47,7 @@
4747
"Arn"
4848
]
4949
},
50-
"Runtime": "nodejs20.x"
50+
"Runtime": "nodejs22.x"
5151
},
5252
"DependsOn": [
5353
"FunctionServiceRole675BB04A"

0 commit comments

Comments
 (0)