Skip to content

Commit e85231c

Browse files
go-to-kgo-to-k
authored
feat(codepipeline): change default pipeline type to V2 (under feature flag) (#29096)
### Reason for this change We discussed about the default pipeline type, it was concluded that the new type (V2) should be the default. #28538 (comment) https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-codepipeline/lib/pipeline.ts#L492 ### Description of changes Change the default value using a feature flag so as not to affect existing processing. ### Description of how you validated changes Bot unit and integ tests ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent a1fbd51 commit e85231c

File tree

63 files changed

+2284
-63
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

63 files changed

+2284
-63
lines changed

‎packages/@aws-cdk-testing/framework-integ/test/aws-appconfig/test/integ.configuration.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,11 @@ def handler(event, context):
3232
print('This is my dummy validator')
3333
`;
3434

35-
const app = new App();
35+
const app = new App({
36+
postCliContext: {
37+
'@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
38+
},
39+
});
3640

3741
const stack = new Stack(app, 'aws-appconfig-configuration');
3842

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/cloudformation/integ.stacksets.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,11 @@ export class StackSetPipelineStack extends Stack {
7676
}
7777
}
7878

79-
const app = new App();
79+
const app = new App({
80+
postCliContext: {
81+
'@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
82+
},
83+
});
8084
const stack = new StackSetPipelineStack(app, 'StackSetPipelineStack');
8185
new IntegTest(app, 'StackSetPipelineStackInteg', {
8286
testCases: [stack],

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.cfn-template-from-repo.lit.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,11 @@ import * as codepipeline from 'aws-cdk-lib/aws-codepipeline';
33
import * as cdk from 'aws-cdk-lib';
44
import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
55

6-
const app = new cdk.App();
6+
const app = new cdk.App({
7+
postCliContext: {
8+
'@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
9+
},
10+
});
711
const stack = new cdk.Stack(app, 'aws-cdk-codepipeline-cloudformation');
812

913
/// !show

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.lambda-deployed-through-codepipeline.lit.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,11 @@ import * as cdk from 'aws-cdk-lib';
77
import * as codepipeline_actions from 'aws-cdk-lib/aws-codepipeline-actions';
88
import { STANDARD_NODEJS_RUNTIME } from '../../config';
99

10-
const app = new cdk.App();
10+
const app = new cdk.App({
11+
postCliContext: {
12+
'@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
13+
},
14+
});
1115

1216
/// !show
1317
const lambdaStack = new cdk.Stack(app, 'LambdaStack');

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.lambda-pipeline.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,11 @@ import * as cdk from 'aws-cdk-lib';
66
import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
77
import { STANDARD_NODEJS_RUNTIME } from '../../config';
88

9-
const app = new cdk.App();
9+
const app = new cdk.App({
10+
postCliContext: {
11+
'@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
12+
},
13+
});
1014

1115
const stack = new cdk.Stack(app, 'aws-cdk-codepipeline-lambda');
1216

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-alexa-deploy.ts

+5-2
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,11 @@ import * as s3 from 'aws-cdk-lib/aws-s3';
33
import { App, RemovalPolicy, SecretValue, Stack } from 'aws-cdk-lib';
44
import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
55

6-
const app = new App();
7-
6+
const app = new App({
7+
postCliContext: {
8+
'@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
9+
},
10+
});
811
const stack = new Stack(app, 'aws-cdk-codepipeline-alexa-deploy');
912

1013
const bucket = new s3.Bucket(stack, 'PipelineBucket', {

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-cfn-cross-region.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,11 @@ import * as s3 from 'aws-cdk-lib/aws-s3';
33
import * as cdk from 'aws-cdk-lib';
44
import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
55

6-
const app = new cdk.App();
6+
const app = new cdk.App({
7+
postCliContext: {
8+
'@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
9+
},
10+
});
711

812
const region = 'us-west-2'; // hardcode the region
913
const stack = new cdk.Stack(app, 'aws-cdk-codepipeline-cloudformation-cross-region', {

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-cfn-with-action-role.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,11 @@ import * as s3 from 'aws-cdk-lib/aws-s3';
44
import * as cdk from 'aws-cdk-lib';
55
import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
66

7-
const app = new cdk.App();
7+
const app = new cdk.App({
8+
postCliContext: {
9+
'@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
10+
},
11+
});
812

913
const stack = new cdk.Stack(app, 'aws-cdk-codepipeline-cloudformation-cross-region-with-action-role', {});
1014

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-cfn.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,11 @@ import * as s3 from 'aws-cdk-lib/aws-s3';
44
import * as cdk from 'aws-cdk-lib';
55
import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
66

7-
const app = new cdk.App();
7+
const app = new cdk.App({
8+
postCliContext: {
9+
'@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
10+
},
11+
});
812

913
const stack = new cdk.Stack(app, 'aws-cdk-codepipeline-cloudformation');
1014

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-code-build-batch.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,11 @@ import * as s3 from 'aws-cdk-lib/aws-s3';
55
import * as cdk from 'aws-cdk-lib';
66
import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
77

8-
const app = new cdk.App();
8+
const app = new cdk.App({
9+
postCliContext: {
10+
'@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
11+
},
12+
});
913

1014
const stack = new cdk.Stack(app, 'aws-cdk-codepipeline-codebuild-batch');
1115

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-code-build-multiple-inputs-outputs.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,11 @@ import * as s3 from 'aws-cdk-lib/aws-s3';
55
import * as cdk from 'aws-cdk-lib';
66
import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
77

8-
const app = new cdk.App();
8+
const app = new cdk.App({
9+
postCliContext: {
10+
'@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
11+
},
12+
});
913

1014
const stack = new cdk.Stack(app, 'aws-cdk-codepipeline-codebuild-multiple-inputs-outputs');
1115

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-code-commit-build.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,11 @@ import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
66

77
/* eslint-disable quote-props */
88

9-
const app = new cdk.App();
9+
const app = new cdk.App({
10+
postCliContext: {
11+
'@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
12+
},
13+
});
1014

1115
const stack = new cdk.Stack(app, 'aws-cdk-codepipeline-codecommit-codebuild');
1216

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-code-commit-custom-event.ts

+6-3
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,18 @@ import * as codecommit from 'aws-cdk-lib/aws-codecommit';
22
import * as codepipeline from 'aws-cdk-lib/aws-codepipeline';
33
import * as cdk from 'aws-cdk-lib';
44
import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
5-
import { CODECOMMIT_SOURCE_ACTION_DEFAULT_BRANCH_NAME } from 'aws-cdk-lib/cx-api';
5+
import { CODECOMMIT_SOURCE_ACTION_DEFAULT_BRANCH_NAME, CODEPIPELINE_DEFAULT_PIPELINE_TYPE_TO_V2 } from 'aws-cdk-lib/cx-api';
66
import { ExpectedResult, IntegTest } from '@aws-cdk/integ-tests-alpha';
77
import { LambdaFunction } from 'aws-cdk-lib/aws-events-targets';
88
import { Code, Runtime, Function } from 'aws-cdk-lib/aws-lambda';
99
import { PolicyStatement } from 'aws-cdk-lib/aws-iam';
1010
import * as path from 'path';
1111

12-
const defaultBranchFeatureFlag = { [CODECOMMIT_SOURCE_ACTION_DEFAULT_BRANCH_NAME]: true };
13-
const app = new cdk.App({ postCliContext: defaultBranchFeatureFlag });
12+
const defaultFeatureFlag = {
13+
[CODECOMMIT_SOURCE_ACTION_DEFAULT_BRANCH_NAME]: true,
14+
[CODEPIPELINE_DEFAULT_PIPELINE_TYPE_TO_V2]: false,
15+
};
16+
const app = new cdk.App({ postCliContext: defaultFeatureFlag });
1417

1518
const stack = new cdk.Stack(app, 'aws-cdk-codepipeline-codecommit-custom-event');
1619
const branch = 'test-branch';

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-code-commit-main.ts

+6-3
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,14 @@ import * as codecommit from 'aws-cdk-lib/aws-codecommit';
22
import * as codepipeline from 'aws-cdk-lib/aws-codepipeline';
33
import * as cdk from 'aws-cdk-lib';
44
import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
5-
import { CODECOMMIT_SOURCE_ACTION_DEFAULT_BRANCH_NAME } from 'aws-cdk-lib/cx-api';
5+
import { CODECOMMIT_SOURCE_ACTION_DEFAULT_BRANCH_NAME, CODEPIPELINE_DEFAULT_PIPELINE_TYPE_TO_V2 } from 'aws-cdk-lib/cx-api';
66
import { IntegTest } from '@aws-cdk/integ-tests-alpha';
77

8-
const defaultBranchFeatureFlag = { [CODECOMMIT_SOURCE_ACTION_DEFAULT_BRANCH_NAME]: true };
9-
const app = new cdk.App({ postCliContext: defaultBranchFeatureFlag });
8+
const defaultFeatureFlag = {
9+
[CODECOMMIT_SOURCE_ACTION_DEFAULT_BRANCH_NAME]: true,
10+
[CODEPIPELINE_DEFAULT_PIPELINE_TYPE_TO_V2]: false,
11+
};
12+
const app = new cdk.App({ postCliContext: defaultFeatureFlag });
1013

1114
const stack = new cdk.Stack(app, 'aws-cdk-codepipeline-codecommit-main');
1215

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-code-commit.ts

+6-5
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,13 @@ import * as codecommit from 'aws-cdk-lib/aws-codecommit';
22
import * as codepipeline from 'aws-cdk-lib/aws-codepipeline';
33
import * as cdk from 'aws-cdk-lib';
44
import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
5-
import { CODECOMMIT_SOURCE_ACTION_DEFAULT_BRANCH_NAME } from 'aws-cdk-lib/cx-api';
5+
import { CODECOMMIT_SOURCE_ACTION_DEFAULT_BRANCH_NAME, CODEPIPELINE_DEFAULT_PIPELINE_TYPE_TO_V2 } from 'aws-cdk-lib/cx-api';
66

7-
const defaultBranchFeatureFlag = { [CODECOMMIT_SOURCE_ACTION_DEFAULT_BRANCH_NAME]: false };
8-
const app = new cdk.App({
9-
postCliContext: defaultBranchFeatureFlag,
10-
});
7+
const defaultFeatureFlag = {
8+
[CODECOMMIT_SOURCE_ACTION_DEFAULT_BRANCH_NAME]: false,
9+
[CODEPIPELINE_DEFAULT_PIPELINE_TYPE_TO_V2]: false,
10+
};
11+
const app = new cdk.App({ postCliContext: defaultFeatureFlag });
1112

1213
const stack = new cdk.Stack(app, 'aws-cdk-codepipeline-codecommit');
1314

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-code-deploy-ecs.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,11 @@ import * as s3 from 'aws-cdk-lib/aws-s3';
44
import * as cdk from 'aws-cdk-lib';
55
import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
66

7-
const app = new cdk.App();
7+
const app = new cdk.App({
8+
postCliContext: {
9+
'@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
10+
},
11+
});
812

913
const stack = new cdk.Stack(app, 'aws-cdk-codepipeline-codedeploy-ecs');
1014

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-code-deploy.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,11 @@ import * as s3 from 'aws-cdk-lib/aws-s3';
44
import * as cdk from 'aws-cdk-lib';
55
import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
66

7-
const app = new cdk.App();
7+
const app = new cdk.App({
8+
postCliContext: {
9+
'@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
10+
},
11+
});
812

913
const stack = new cdk.Stack(app, 'aws-cdk-codepipeline-codedeploy');
1014

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-ecr-source.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,11 @@ import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
2424
* was triggered successfully.
2525
*/
2626

27-
const app = new cdk.App();
27+
const app = new cdk.App({
28+
postCliContext: {
29+
'@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
30+
},
31+
});
2832

2933
const stack = new cdk.Stack(app, 'aws-cdk-codepipeline-ecr-source');
3034

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-ecs-deploy.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,11 @@ import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
99

1010
/* eslint-disable quote-props */
1111

12-
const app = new cdk.App();
12+
const app = new cdk.App({
13+
postCliContext: {
14+
'@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
15+
},
16+
});
1317

1418
const stack = new cdk.Stack(app, 'aws-cdk-codepipeline-ecs-deploy');
1519

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-elastic-beanstalk-deploy.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,11 @@ import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
2121
* 5. Manually delete the 'aws-cdk-codepipeline-elastic-beanstalk-deploy' stack
2222
*/
2323

24-
const app = new App();
24+
const app = new App({
25+
postCliContext: {
26+
'@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
27+
},
28+
});
2529

2630
const stack = new Stack(app, 'aws-cdk-codepipeline-elastic-beanstalk-deploy');
2731

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-events.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,11 @@ import * as sns from 'aws-cdk-lib/aws-sns';
99
import * as cdk from 'aws-cdk-lib';
1010
import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
1111

12-
const app = new cdk.App();
12+
const app = new cdk.App({
13+
postCliContext: {
14+
'@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
15+
},
16+
});
1317

1418
const stack = new cdk.Stack(app, 'aws-cdk-pipeline-event-target');
1519

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-jenkins.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,11 @@ import * as s3 from 'aws-cdk-lib/aws-s3';
33
import * as cdk from 'aws-cdk-lib';
44
import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
55

6-
const app = new cdk.App();
6+
const app = new cdk.App({
7+
postCliContext: {
8+
'@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
9+
},
10+
});
711

812
const stack = new cdk.Stack(app, 'aws-cdk-codepipeline-jenkins');
913

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-manual-approval.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,11 @@ import * as s3 from 'aws-cdk-lib/aws-s3';
33
import * as cdk from 'aws-cdk-lib';
44
import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
55

6-
const app = new cdk.App();
6+
const app = new cdk.App({
7+
postCliContext: {
8+
'@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
9+
},
10+
});
711

812
const stack = new cdk.Stack(app, 'aws-cdk-codepipeline-manual-approval');
913

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-s3-deploy.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,11 @@ import { Duration } from 'aws-cdk-lib';
66
import { IntegTest, ExpectedResult, Match } from '@aws-cdk/integ-tests-alpha';
77
import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
88

9-
const app = new cdk.App();
9+
const app = new cdk.App({
10+
postCliContext: {
11+
'@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
12+
},
13+
});
1014

1115
const stack = new cdk.Stack(app, 'aws-cdk-codepipeline-s3-deploy');
1216

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-stepfunctions.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,11 @@ import * as stepfunctions from 'aws-cdk-lib/aws-stepfunctions';
44
import * as cdk from 'aws-cdk-lib';
55
import * as cpactions from 'aws-cdk-lib/aws-codepipeline-actions';
66

7-
const app = new cdk.App();
7+
const app = new cdk.App({
8+
postCliContext: {
9+
'@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
10+
},
11+
});
812

913
const stack = new cdk.Stack(app, 'aws-cdk-codepipeline-stepfunctions');
1014

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-type-v2-by-default.js.snapshot/asset.54e6f07bf3aea46d100719f3b21fe0fb45ae789ee372d42d8cdfb97e21aba96c/index.js

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-type-v2-by-default.js.snapshot/aws-cdk-codepipeline-pipeline-type-v2-by-default.assets.json

+32
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)