Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: canonicalize service name of Amazon Data Firehose #33757

Merged
merged 20 commits into from
Mar 13, 2025

Conversation

Tietew
Copy link
Contributor

@Tietew Tietew commented Mar 13, 2025

Reason for this change

Docs in CDK sometimes refer the Amazon Data Firehose as former name "(Amazon) Kinesis Data Firehose" or "(Amazon) Kinesis Firehose". This PR updates them to canonical "Amazon Data Firehose".

Description of changes

  • Fixed dangling links in packages/aws-cdk-lib/aws-kinesisfirehose/README.md
  • Updated README and docstrings to refer Amazon Data Firehose
  • Updated examples refer @aws-cdk/aws-kinesisfirehose-alpha
  • Following files are not changed:
    • Changelog entries
    • Test files
    • aws-kinesisfirehose alpha packages
    • .github/ISSUE_TEMPLATE
    • packages/@aws-cdk/pkglint/lib/aws-service-official-names.json

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Mar 13, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 13, 2025 03:57
Tietew added a commit to Tietew/aws-cdk that referenced this pull request Mar 13, 2025
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (f67a88b) to head (fb7a085).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33757   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         120      120           
  Lines        6937     6937           
  Branches     1170     1170           
=======================================
  Hits         5715     5715           
  Misses       1119     1119           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.38% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 13, 2025
@paulhcsun paulhcsun self-assigned this Mar 13, 2025
Copy link
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making these updates!

@paulhcsun
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Mar 13, 2025

update

✅ Branch has been successfully updated

Copy link
Contributor

mergify bot commented Mar 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 13, 2025
Copy link
Contributor

mergify bot commented Mar 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: fb7a085
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Mar 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a7633a9 into aws:main Mar 13, 2025
20 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2025
@Tietew Tietew deleted the firehose-docs-update branch March 14, 2025 02:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants