Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(batch): add note on update fatgate compute environment #34022

Merged
merged 4 commits into from
Apr 7, 2025
Merged

docs(batch): add note on update fatgate compute environment #34022

merged 4 commits into from
Apr 7, 2025

Conversation

deftcx-aws
Copy link
Contributor

…ments

Issue #34008

Closes #34008.

Reason for this change

Describe the issue

aws-cdk-lib.aws_batch.FargateComputeEnvironment needs to be updated for Fargate CEs

This doc is not consistent with other docs:

https://docs.aws.amazon.com/batch/latest/userguide/updating-compute-environments.html
https://docs.aws.amazon.com/cli/latest/reference/batch/update-compute-environment.html

Following fields in FargateComputeEnvironmentProps of FargateComputeEnvironment are not applicable. We might not be able to change model now as it is out, we can update documentation to reflect it is not applicable.

All these params are optional ? .

replaceComputeEnvironment?
terminateOnUpdate?
updateTimeout?
updateToLatestImageVersion?

Links

https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-batch/README.md

Description of changes

Update README, following the instructions in the issue.

Describe any new or updated permissions being added

No.

Description of how you validated changes

No, only README change.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 2, 2025 18:07
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Apr 2, 2025
@deftcx-aws deftcx-aws mentioned this pull request Apr 2, 2025
Closed
aws-cdk-automation
aws-cdk-automation previously requested changes Apr 2, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@deftcx-aws deftcx-aws changed the title Update README to add guidance on Updating AWS Fargate compute environ… chore(batch): add note on update fatgate compute environment Apr 2, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 2, 2025 18:27

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 2, 2025
@paulhcsun paulhcsun changed the title chore(batch): add note on update fatgate compute environment docs(batch): add note on update fatgate compute environment Apr 7, 2025
@paulhcsun
Copy link
Contributor

@Mergifyio update

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 7, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 7, 2025

update

✅ Branch has been successfully updated

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@codecov Codecov
Copy link

codecov bot commented Apr 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (74cbe27) to head (3ff7289).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #34022   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         120      120           
  Lines        6976     6976           
  Branches     1178     1178           
=======================================
  Hits         5859     5859           
  Misses       1005     1005           
  Partials      112      112
Flag Coverage Δ
suite.unit 83.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 83.98% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3ff7289
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1b98a41 into aws:main Apr 7, 2025
20 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulhcsun paulhcsun paulhcsun approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(/aws-batch): Update README to add guidance on Updating AWS Fargate compute environments
3 participants
@deftcx-aws @paulhcsun @aws-cdk-automation