fix(lambda): allow retryAttempts = -1 for infinite retries in EventSourceMapping

[pahud]

Issue # (if applicable)

Fixes #34007

This PR addresses an inconsistency in the validation logic for the retryAttempts property of Lambda EventSourceMapping.

Previously, although the documentation indicated that -1 signifies infinite retries (and is the default), explicitly setting retryAttempts: -1 would cause a ValidationError because the validation logic enforced a lower bound of 0.

This change updates the validation in aws-cdk-lib/aws-lambda/lib/event-source-mapping.ts to correctly allow -1 as a valid value, aligning the implementation with the documented behavior.

Additionally, this PR includes:

• Updates to the TSDoc for retryAttempts in aws-cdk-lib/aws-lambda-event-sources/lib/stream.ts to improve clarity regarding the valid range (-1 or 0 to 10000).
• Updates to the unit tests in aws-cdk-lib/aws-lambda/test/event-source-mapping.test.ts to verify the corrected behavior.

Affected modules: aws-lambda, aws-lambda-event-sources

Reason for this change

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

(This review is outdated)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (0923b5e) to head (a108680).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #34009   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         120      120           
  Lines        6976     6976           
  Branches     1178     1178           
=======================================
  Hits         5859     5859           
  Misses       1005     1005           
  Partials      112      112           

Flag	Coverage Δ
suite.unit	83.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	∅ <ø> (∅)
packages/aws-cdk-lib/core	83.98% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[godwingrs22]

Hi @pahud, seems the build is failing because of the another unit test[aws-lambda-event-sources/lib/dynamodb.ts] that needs to be updated.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: a108680
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.