Skip to content

[keyring] clarify naming of AWS KMS keyring #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mattsb42-aws opened this issue Apr 16, 2020 · 1 comment · Fixed by #253
Closed

[keyring] clarify naming of AWS KMS keyring #252

mattsb42-aws opened this issue Apr 16, 2020 · 1 comment · Fixed by #253
Assignees
@mattsb42-aws
Labels
blocking next release doc impact
Milestone
keyrings

Comments

@mattsb42-aws
Copy link
Member

Per awslabs/aws-encryption-sdk-specification#67, we are going to rename KmsKeyring to AwsKmsKeyring to be explicitly clear that this keyring interacts with the AWS Key Management Service, rather than some other KMS.
@mattsb42-aws mattsb42-aws added this to the keyrings milestone Apr 16, 2020
@mattsb42-aws mattsb42-aws self-assigned this Apr 16, 2020
@mattsb42-aws mattsb42-aws mentioned this issue Apr 16, 2020
Merged
1 task
@acioc acioc mentioned this issue Jun 3, 2020
Open
@acioc
Copy link

acioc commented Jun 3, 2020

Spec issue merged. Spec issue tracking the completion of this implementation in awslabs/aws-encryption-sdk-specification#127 (adding link here so it properly links and shows up as closed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattsb42-aws mattsb42-aws

Labels
blocking next release doc impact
Projects
None yet
Milestone
keyrings
Development

Successfully merging a pull request may close this issue.

feat: change from KmsKeyring to AwsKmsKeyring
2 participants
@acioc @mattsb42-aws